On Thu, 2005-12-08 at 13:44 +0000, Christoph Hellwig wrote: > On Thu, Dec 08, 2005 at 01:39:45PM +0000, Matthew Garrett wrote: > > On Thu, Dec 08, 2005 at 01:33:08PM +0000, Christoph Hellwig wrote: > > > > > Don't do it at all. We don't need to fuck up every layer and driver for > > > intels braindamage. > > > > Doing SATA suspend/resume properly on x86 depends on knowing the ACPI > > object that corresponds to a host or target. It's also the only way to > > support hotswap on this hardware[1], since there's no way for userspace > > to know which device a notification refers to. > > Well, bad luck for people buying such broken hardware. Maybe you can trick > Jeff into adding junk like that to libata, but it surely doesn't have any > business in the scsi layer. 'guess You're not interested in having suspend/resume actually work on laptops (or other PC's). That's your prerogative but imho it's a bit narrow-minded to withhold this functionality from other people who actually would like to have this working, just because you happen to not like ACPI.