From: Ben Collins <ben.collins@ubuntu.com>
To: Jens Axboe <axboe@suse.de>
Cc: john stultz <johnstul@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: Re: [RFC] Let non-root users eject their ipods?
Date: Tue, 20 Dec 2005 08:32:37 -0500 [thread overview]
Message-ID: <1135085557.16754.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20051220132821.GH3734@suse.de>
On Tue, 2005-12-20 at 14:28 +0100, Jens Axboe wrote:
> On Tue, Dec 20 2005, Ben Collins wrote:
> > On Tue, 2005-12-20 at 08:46 +0100, Jens Axboe wrote:
> > > On Mon, Dec 19 2005, john stultz wrote:
> > > > All,
> > > > I'm getting a little tired of my roommates not knowing how to safely
> > > > eject their usb-flash disks from my system and I'd personally like it if
> > > > I could avoid bringing up a root shell to eject my ipod. Sure, one could
> > > > suid the eject command, but that seems just as bad as changing the
> > > > permissions in the kernel (eject wouldn't be able to check if the user
> > > > has read/write permissions on the device, allowing them to eject
> > > > anything).
> > >
> > > This just came up yesterday, eject isn't opening the device RDWR hence
> > > you have a permission problem with a command requiring write
> > > permissions. So just fix eject, there's no need to suid eject or run it
> > > as root.
> >
> > Yep, and here's the patch to do it:
> >
> > http://bugzilla.ubuntu.com/attachment.cgi?id=5415
> >
> > Still, this whole issue with ALLOW_MEDIUM_REMOVAL. Would be nice if
> > CDROMEJECT just did the right thing.
>
> I would tend to agree, but you are bypassing the checks that are in
> there by doing so which isn't very nice. Then we might as well just mark
> ALLOW_MEDIUM_REMOVAL as safe-for-read in the first place.
Should be an easy check to add. In fact, I'll resend both patches with
that in place if you want.
--
Ben Collins <ben.collins@ubuntu.com>
Developer
Ubuntu Linux
next prev parent reply other threads:[~2005-12-20 13:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 2:51 [RFC] Let non-root users eject their ipods? john stultz
2005-12-20 3:51 ` Wakko Warner
2005-12-20 3:49 ` john stultz
2005-12-20 5:05 ` Matthew Dharm
2005-12-24 21:16 ` Jan Engelhardt
2005-12-20 5:18 ` Willy Tarreau
2005-12-20 6:06 ` Coywolf Qi Hunt
2005-12-20 8:56 ` Sander
2005-12-20 9:31 ` Coywolf Qi Hunt
2005-12-20 9:38 ` Sander
2005-12-20 16:39 ` Bill Davidsen
2005-12-20 11:10 ` Nikita Danilov
2005-12-20 7:46 ` Jens Axboe
2005-12-20 12:41 ` Ben Collins
2005-12-20 13:28 ` Jens Axboe
2005-12-20 13:32 ` Ben Collins [this message]
2005-12-20 13:39 ` Jens Axboe
2005-12-20 14:07 ` [PATCH] block: Better CDROMEJECT Ben Collins
2005-12-20 14:16 ` Jens Axboe
2005-12-20 20:41 ` john stultz
2005-12-20 20:54 ` Jens Axboe
2005-12-20 20:55 ` john stultz
2005-12-20 20:58 ` Jens Axboe
2005-12-20 20:58 ` john stultz
2005-12-20 20:55 ` Ben Collins
2005-12-20 16:48 ` [RFC] Let non-root users eject their ipods? Bill Davidsen
2005-12-22 10:56 ` Alan Cox
2005-12-22 16:57 ` john stultz
2005-12-24 21:17 ` Jan Engelhardt
[not found] <5lFTx-7L1-9@gated-at.bofh.it>
[not found] ` <5lIeC-3hP-3@gated-at.bofh.it>
[not found] ` <5lIRn-4GE-19@gated-at.bofh.it>
[not found] ` <5lLw7-1f5-43@gated-at.bofh.it>
[not found] ` <5lM8s-2D4-1@gated-at.bofh.it>
[not found] ` <5lM8F-2D4-39@gated-at.bofh.it>
[not found] ` <5lSQE-87T-9@gated-at.bofh.it>
2005-12-20 20:21 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135085557.16754.2.camel@localhost.localdomain \
--to=ben.collins@ubuntu.com \
--cc=axboe@suse.de \
--cc=greg@kroah.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).