From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161348AbWALWG5 (ORCPT ); Thu, 12 Jan 2006 17:06:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161332AbWALWG4 (ORCPT ); Thu, 12 Jan 2006 17:06:56 -0500 Received: from viper.oldcity.dca.net ([216.158.38.4]:64982 "HELO viper.oldcity.dca.net") by vger.kernel.org with SMTP id S1161349AbWALWG4 (ORCPT ); Thu, 12 Jan 2006 17:06:56 -0500 Subject: Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware From: Lee Revell To: Adrian Bunk Cc: Muli Ben-Yehuda , Jiri Slaby , Jon Mason , linux-kernel@vger.kernel.org In-Reply-To: <20060112215853.GW29663@stusta.de> References: <20060112175051.GA17539@us.ibm.com> <43C6ADDE.5060904@liberouter.org> <20060112200735.GD5399@granada.merseine.nu> <1137100539.2370.68.camel@mindpipe> <20060112215853.GW29663@stusta.de> Content-Type: text/plain Date: Thu, 12 Jan 2006 17:06:53 -0500 Message-Id: <1137103614.2370.75.camel@mindpipe> Mime-Version: 1.0 X-Mailer: Evolution 2.5.4 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2006-01-12 at 22:58 +0100, Adrian Bunk wrote: > On Thu, Jan 12, 2006 at 04:15:38PM -0500, Lee Revell wrote: > > On Thu, 2006-01-12 at 22:07 +0200, Muli Ben-Yehuda wrote: > > > On Thu, Jan 12, 2006 at 08:28:30PM +0100, Jiri Slaby wrote: > > > > > > > You should change alsa driver (sound/pci/trident/trident.c), rather than this, > > > > which will be removed soon, I guess. And, additionally, could you change that > > > > lines to use PCI_DEVICE macro? > > > > > > This driver is not up for removal soon, as it supports a device that > > > the alsa driver apparently doesn't (the INTERG_5050). > > > > When were you going to report this? > > I already reported this as ALSA bug #1293. > > The problem is the lack of a tester, and I'm currently inclined to > schedule this driver for removal although this PCI ID is still missing - > either noone is using these settop boxes anymore or someone will > volunteer to test patches. Hmm, yeah, if the hardware was only used in set top boxes there's not a lot that can be done, unless someone wants to donate one to the ALSA project. It might be as simple as adding the PCI IDs to the driver. Lee