From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 5/13] s390: show_task oops.
Date: Fri, 13 Jan 2006 09:45:42 +0100 [thread overview]
Message-ID: <1137141942.6192.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20060112165826.5843e34c.akpm@osdl.org>
On Thu, 2006-01-12 at 16:58 -0800, Andrew Morton wrote:
> Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> >
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> >
> > [patch 5/13] s390: show_task oops.
> >
> > The show_task function walks the kernel stack backchain of
> > processes assuming that the processes are not running. Since
> > this assumption is not correct walking the backchain can lead
> > to an addressing exception and therefore to a kernel hang.
> > So prevent the kernel hang (you still get incorrect results)
> > verity that all read accesses are within the bounds of the
> > kernel stack before performing them.
> >
>
> This one needs to be thought about and tested versus the just-merged
> s390-task_stack_page.patch. I guess it'll still work, but some of the
> pretty new accessors could be used in there, at least.
Oh yes, didn't notice that Al Viro's task_thread_info() changes got
merged in the meantime. We'll test & send a follow-up patch.
--
blue skies,
Martin
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
next prev parent reply other threads:[~2006-01-13 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 17:15 [patch 5/13] s390: show_task oops Martin Schwidefsky
2006-01-13 0:58 ` Andrew Morton
2006-01-13 8:45 ` Martin Schwidefsky [this message]
2006-01-13 12:24 ` [PATCH] s390: show_task oops fix Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137141942.6192.5.camel@localhost.localdomain \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).