From: "Ronald S. Bultje" <rbultje@ronald.bitfreak.net>
To: Andrew Morton <akpm@osdl.org>, Jean Delvare <khali@linux-fr.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Subject: Re: [PATCH] Fix zoran_card compilation warning
Date: Sun, 15 Jan 2006 09:44:39 -0500 [thread overview]
Message-ID: <1137336280.7095.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20060115131313.04657ef5.khali@linux-fr.org>
Hi Linus/Andrew,
On Sun, 2006-01-15 at 13:13 +0100, Jean Delvare wrote:
> CC [M] drivers/media/video/zoran_card.o
> drivers/media/video/zoran_card.c: In function `zr36057_init':
> drivers/media/video/zoran_card.c:1053: warning: assignment makes integer from pointer without a cast
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/media/video/zoran_card.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.15-git.orig/drivers/media/video/zoran_card.c 2006-01-12 20:34:54.000000000 +0100
> +++ linux-2.6.15-git/drivers/media/video/zoran_card.c 2006-01-12 20:47:26.000000000 +0100
> @@ -995,7 +995,7 @@
> static int __devinit
> zr36057_init (struct zoran *zr)
> {
> - unsigned long mem;
> + u32 *mem;
> void *vdev;
> unsigned mem_needed;
> int j;
> @@ -1058,10 +1058,10 @@
> "%s: zr36057_init() - kmalloc (STAT_COM) failed\n",
> ZR_DEVNAME(zr));
> kfree(vdev);
> - kfree((void *)mem);
> + kfree(mem);
> return -ENOMEM;
> }
> - zr->stat_com = (u32 *) mem;
> + zr->stat_com = mem;
> for (j = 0; j < BUZ_NUM_STAT_COM; j++) {
> zr->stat_com[j] = 1; /* mark as unavailable to zr36057 */
> }
>
I support this change, please apply it. It's something left-over from
the time that all computers were 32-bit. Apart from this warning (which
nobody really cared about), the driver was already tested to work fine
on AMD64 computers in 64-bit mode.
Thank you,
Ronald
prev parent reply other threads:[~2006-01-15 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 20:34 [PATCH] Fix zoran_card compilation warning Jean Delvare
2006-01-15 12:13 ` Jean Delvare
2006-01-15 14:44 ` Ronald S. Bultje [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137336280.7095.4.camel@localhost.localdomain \
--to=rbultje@ronald.bitfreak.net \
--cc=akpm@osdl.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).