From: "Bryan O'Sullivan" <bos@serpentine.com>
To: Andrew Morton <akpm@osdl.org>,
arnd@arndb.de, david@gibson.dropbear.id.au
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix sparse parse error in lppaca.h
Date: Tue, 17 Jan 2006 16:34:25 -0800 [thread overview]
Message-ID: <1137544465.4757.13.camel@serpentine.pathscale.com> (raw)
sparse can't parse a struct definition in include/asm-powerpc/lppaca.h,
even though gcc can accept it. The form looks like this:
struct __attribute__((whatever)) foo { };
An equivalent that both gcc and sparse can handle is
struct foo { } __attribute__((whatever));
This is the only definition of this type in the tree, and fixing it is
easier than fixing sparse.
Signed-off-by: Bryan O'Sullivan <bos@serpentine.com>
diff -r 89be36ca2767 include/asm-powerpc/lppaca.h
--- a/include/asm-powerpc/lppaca.h Wed Jan 18 04:00:05 2006 +0000
+++ b/include/asm-powerpc/lppaca.h Tue Jan 17 16:27:27 2006 -0800
@@ -31,7 +31,7 @@
/* The Hypervisor barfs if the lppaca crosses a page boundary. A 1k
* alignment is sufficient to prevent this */
-struct __attribute__((__aligned__(0x400))) lppaca {
+struct lppaca {
//=============================================================================
// CACHE_LINE_1 0x0000 - 0x007F Contains read-only data
// NOTE: The xDynXyz fields are fields that will be dynamically changed by
@@ -129,7 +129,7 @@
// CACHE_LINE_4-5 0x0100 - 0x01FF Contains PMC interrupt data
//=============================================================================
u8 pmc_save_area[256]; // PMC interrupt Area x00-xFF
-};
+} __attribute__((__aligned__(0x400)));
extern struct lppaca lppaca[];
next reply other threads:[~2006-01-18 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 0:34 Bryan O'Sullivan [this message]
2006-01-18 2:55 ` [PATCH] Fix sparse parse error in lppaca.h David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137544465.4757.13.camel@serpentine.pathscale.com \
--to=bos@serpentine.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).