From: Roland Dreier <rolandd@cisco.com>
To: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [git patch review 3/5] IB/sa_query: Flush scheduled work before unloading module
Date: Sat, 21 Jan 2006 22:03:10 +0000 [thread overview]
Message-ID: <1137880990999-449ff8b55b88bcaa@cisco.com> (raw)
In-Reply-To: <1137880990999-7ca1217bcd8a8383@cisco.com>
sa_query schedules work on IB asynchronous events. After
unregistering the async event handler, make sure that this work has
completed before releasing the IB device (and possibly allowing the
sa_query module text to go away).
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
drivers/infiniband/core/sa_query.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
0f47ae0b3ec35dc5f4723f2e0ad0f6f3f55e9bcd
diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c
index acda7d6..501cc05 100644
--- a/drivers/infiniband/core/sa_query.c
+++ b/drivers/infiniband/core/sa_query.c
@@ -956,6 +956,8 @@ static void ib_sa_remove_one(struct ib_d
ib_unregister_event_handler(&sa_dev->event_handler);
+ flush_scheduled_work();
+
for (i = 0; i <= sa_dev->end_port - sa_dev->start_port; ++i) {
ib_unregister_mad_agent(sa_dev->port[i].agent);
kref_put(&sa_dev->port[i].sm_ah->ref, free_sm_ah);
--
1.1.3
next prev parent reply other threads:[~2006-01-21 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 22:03 [git patch review 1/5] IPoIB: Make sure path is fully initialized before using it Roland Dreier
2006-01-21 22:03 ` [git patch review 2/5] IB/uverbs: Flush scheduled work before unloading module Roland Dreier
2006-01-21 22:03 ` Roland Dreier [this message]
2006-01-21 22:03 ` [git patch review 4/5] IPoIB: Lock accesses to multicast packet queues Roland Dreier
2006-01-21 22:03 ` [git patch review 5/5] IB/mthca: Use correct GID in MADs sent on port 2 Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137880990999-449ff8b55b88bcaa@cisco.com \
--to=rolandd@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).