From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FDC8CA0FF7 for ; Fri, 1 Sep 2023 18:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350572AbjIASVe (ORCPT ); Fri, 1 Sep 2023 14:21:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350550AbjIASVc (ORCPT ); Fri, 1 Sep 2023 14:21:32 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 308CA1702; Fri, 1 Sep 2023 11:21:26 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-79266c8617eso80311839f.3; Fri, 01 Sep 2023 11:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693592485; x=1694197285; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=AkxZWqWdmQ7F4OBr4vVbCBrNJyUi6XIXCKckh3E053I=; b=UFRW04TiecSbnPNUr7wqXSpFxNrqEc51JgS91Ow0fFG5Jy0T2ZTHpLWc3r8ObBdh56 F1KihHTTpAGF4HM906FFVDWja2pkakbq2J1xI46JGa2ahiHT0oDdBQoi7yYUAVSb26Zl sgYMkedEbTr+DkddKVb57FYTnZDMTvnkb4bXCjyxz3J6EptElGsOD9fF4GUG0aw2l9Pf SsZav94dCOMgBxRScvTbVIyPhjYQbX+THyHu6zsESZalVMr0g6mKUUAah14HIyVUtgZD TQanHveQnxatEcD8r8070U9rNwOOi9TYzNGZdi/dAWk9zaO2i3YToZ8wJHZVpgP1JLVv 1U7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693592485; x=1694197285; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AkxZWqWdmQ7F4OBr4vVbCBrNJyUi6XIXCKckh3E053I=; b=OnlooigOd18Dl5//uVOqdZC1A0LZiQT+Mg8NkDyWDbbceuy+k2h2xVjvJUc98ijKRN ise0+9iN/68w90QvwtK3xQRppc0pCuUddxVJOOl7hOQwAGgPsiouSZgPPasj6SSm7LMW Gh+2MqxuiZZoQRx/xvSCtRCh0UOAf+BWmWX8oxfwqvtBoootI+6B47vGL6oWKDHVFKfs wSIzwtl9+s9iODOZJ5XYtnnny++ciFuXXUNrJtIhkLXkIloatxmPLamlAQCumvOEsKyx 8j+8z4sUpxFgRcgiCa2FaMYa5cDf7LCCcBGwia1lG4kIsGdiIPI3I1/7nXYYXpW5QgDP Vq7g== X-Gm-Message-State: AOJu0YwilPNi1c75BSNvUwYNL/OtHMvCXIF+D/D7AwRVXUF80zviimUl 9rYF2RdjfTvzQ1eKJmUEc0A= X-Google-Smtp-Source: AGHT+IEbBMcZsXGlB1GUVHhi2Pihj+qc2rFLgCVuWcgWXsrzuhONf+cH6SWBxsrTojrGnCA9s4rMBQ== X-Received: by 2002:a5e:9505:0:b0:791:6aa4:2d89 with SMTP id r5-20020a5e9505000000b007916aa42d89mr3489073ioj.21.1693592485543; Fri, 01 Sep 2023 11:21:25 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id e2-20020a056638020200b0041e328a2084sm1168921jaq.79.2023.09.01.11.21.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Sep 2023 11:21:24 -0700 (PDT) Sender: Guenter Roeck Message-ID: <11390a1e-932f-8979-1547-f4555920fb7a@roeck-us.net> Date: Fri, 1 Sep 2023 11:21:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init() Content-Language: en-US To: Nikolay Borisov , Thomas Gleixner Cc: LKML , x86@kernel.org, Linus Torvalds , "Ahmed S. Darwish" , Arnd Bergmann , Russell King , linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , linux-sh@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Richard Henderson , "James E.J. Bottomley" , Michael Ellerman , Chris Zankel , Tom Lendacky , semenzato@google.com References: <20230613223827.532680283@linutronix.de> <20230613224545.902376621@linutronix.de> <20f025f9-35d9-1f35-f21e-38e1bb44b74c@suse.com> From: Guenter Roeck In-Reply-To: <20f025f9-35d9-1f35-f21e-38e1bb44b74c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/1/23 11:00, Nikolay Borisov wrote: > > > On 1.09.23 г. 20:30 ч., Guenter Roeck wrote: >> Hi, >> >> On Wed, Jun 14, 2023 at 01:39:46AM +0200, Thomas Gleixner wrote: >>> Initializing the FPU during the early boot process is a pointless >>> exercise. Early boot is convoluted and fragile enough. >>> >>> Nothing requires that the FPU is set up early. It has to be initialized >>> before fork_init() because the task_struct size depends on the FPU register >>> buffer size. >>> >>> Move the initialization to arch_cpu_finalize_init() which is the perfect >>> place to do so. >>> >>> No functional change. >>> >>> This allows to remove quite some of the custom early command line parsing, >>> but that's subject to the next installment. >>> >>> Signed-off-by: Thomas Gleixner >> >> The backport of this patch into chromeos-5.10 and chromeos-5.15 via stable >> relase merges is causing various Chromebooks (not all of them) to crash >> early during boot. Subsequent fixes have not addressed the problem for us, >> so we already reverted the patch from chromeos-5.15 and will revert it >> from chromeos-5.10 as well. >> >> I don't know if this is a Chromebook specific problem, or if it affects >> mainline, so this is just a heads-up in case others experience similar >> problems. > > > Looking at 5.15 the following prerequisites are likely missing: > > af8060279968 ("mm: Move mm_cachep initialization to mm_init()") > 5b93a83649c7 ("x86/mm: Initialize text poking earlier") > > > Can you test with those patches backported to 5.15.y and see if it works? Both patches are already in v5.10.y and 5.15.y, so unfortunately that doesn't help. Guenter