From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750954AbWBFEMs (ORCPT ); Sun, 5 Feb 2006 23:12:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750952AbWBFEMs (ORCPT ); Sun, 5 Feb 2006 23:12:48 -0500 Received: from gate.crashing.org ([63.228.1.57]:25220 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S1750946AbWBFEMr (ORCPT ); Sun, 5 Feb 2006 23:12:47 -0500 Subject: Re: RFC: Compact Flash True IDE Mode Driver From: Benjamin Herrenschmidt To: Kumar Gala Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Date: Mon, 06 Feb 2006 15:13:27 +1100 Message-Id: <1139199208.4994.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2006-02-01 at 01:19 -0600, Kumar Gala wrote: > I was hoping to get some comments on this work in progress driver for > using a compact flash device running in True IDE Mode connect via a MMIO > interface. The driver is working, however the embedded system I'm running > on need some HW fixes to address the fact that the byte lanes for the data > are swapped. I figured now was a good time to incorporate any changes > while I wait for the HW fixes (which will allow me to remove the > cfide_outsw & cfide_insw). Your driver basically boils down to a simple IDE host driver configured by platform functions. I suggest you remove "compact flash" here and have the platform resource optinally be either PIO or MMIO and you magically get a "generic" IDE driver useable by a lot of simple embedded machines (it assumes all timing related things have been handled by the firmware). Want to be sneakier ? Add a timing setup callback to the platform data you pass to it and you get one that can even do PIO modes :) Ben.