From: <Tudor.Ambarus@microchip.com>
To: <robimarko@gmail.com>
Cc: <bbrezillon@kernel.org>, <richard@nod.at>,
<linux-kernel@vger.kernel.org>, <marek.vasut@gmail.com>,
<linux-mtd@lists.infradead.org>, <computersforpeace@gmail.com>,
<dwmw2@infradead.org>, <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: Add Winbond w25q16jv support
Date: Thu, 13 Jun 2019 14:33:06 +0000 [thread overview]
Message-ID: <113ffb44-b5a4-be63-d75e-0c5819f65604@microchip.com> (raw)
In-Reply-To: <CAOX2RU5MsnNLseBRqcp1KqbmQ+5_KzRyTQ_rGQB2DsrW_v-3iA@mail.gmail.com>
Hi, Robert,
On 02/21/2019 10:58 PM, Robert Marko wrote:
> On Wed, 20 Feb 2019 at 21:29, <Tudor.Ambarus@microchip.com> wrote:>>
> Hi, Robert,>> On 02/14/2019 10:57 PM, Robert Marko wrote:> >
> Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf>
>>>> Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19
> kernel.>> It is preferable to do the test on spi-nor/nextUnfortunately
> I cant do that as OpenWrt has a considerable amount of patches that
> would need to be ported and we are only moving from LTS to LTS version
> and we are currently on 4.19.
>>>
>>> Test board does not support Dual or Quad modes.
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>> drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>>> index 6e13bbd1aaa5..0e958f48db1b 100644
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = {
>>> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>> },
>>> + {
>>> + "w25q16jv", INFO(0xef7015, 0, 64 * 1024, 32,
>>> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>
>> You'll need a way to differentiate between W25Q16JV-IQ/JQ and W25Q16JV-IM/JM.
> Hm, from what I understood JV is the series and suffix only indictes
> the package.
> They should all have the same JEDEC ID and features.
>>
W25Q16JV-IQ/JQ and W25Q16JV-IM/JM have different jedec ids, see table "9.1.1
Manufacturer and Device Identification" from the datasheet that you indicated in
the commit message.
Looking at "12. ORDERING INFORMATION", I see that:
- Q version has QE = 1 (fixed) and it's backward compatible to FV family
- M version has QE = 0 (programmable) and has a new device ID
The same is described in "8. QUAD ENABLE (QE) – Volatile/Non-Volatile Writable".
I would suggest to name the flash "w25q16jv-im/jm".
What do you think?
ta
prev parent reply other threads:[~2019-06-13 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 20:57 [PATCH] mtd: spi-nor: Add Winbond w25q16jv support Robert Marko
2019-02-20 20:29 ` Tudor.Ambarus
2019-02-21 20:58 ` Robert Marko
2019-06-13 14:33 ` Tudor.Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=113ffb44-b5a4-be63-d75e-0c5819f65604@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robimarko@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).