From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Alasdair G Kergon <agk@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Chris McDermott <lcm@us.ibm.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
Date: Wed, 22 Feb 2006 16:46:57 -0800 [thread overview]
Message-ID: <1140655617.3300.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20060222223240.GI31641@agk.surrey.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
Looks good and tests ok, with one issue: I still have a preference for
returning -ENOTTY over 0/0/0 when dm doesn't know the geometry. That
said, most programs will see the zero cylinder count and make a guess,
so it probably doesn't matter.
If you're happy with it, I say put it in. Thanks for the cleanup, by
the way!
--Darrick
On Wed, 2006-02-22 at 22:32 +0000, Alasdair G Kergon wrote:
> On Fri, Feb 17, 2006 at 04:59:58PM -0800, Darrick J. Wong wrote:
> > Here's the third revision, with the geometry pushed into mapped_device
> > as well as fixes for the problems that you pointed out wrt string
> > passing, lack of warning messages, etc. Thanks for all the great feedback!
>
> Almost there now: how does the version below look?
> Corresponding userspace changes are in device-mapper CVS.
>
> Alasdair
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-02-23 0:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 20:22 [PATCH] User-configurable HDIO_GETGEO for dm volumes Darrick J. Wong
2006-02-16 3:05 ` Andrew Morton
2006-02-17 1:31 ` Darrick J. Wong
2006-02-17 1:49 ` Andrew Morton
2006-02-17 15:16 ` Alasdair G Kergon
2006-02-17 15:21 ` [dm-devel] " Alasdair G Kergon
2006-02-18 0:59 ` Darrick J. Wong
2006-02-19 1:25 ` [dm-devel] " Alasdair G Kergon
2006-02-22 22:32 ` Alasdair G Kergon
2006-02-23 0:46 ` Darrick J. Wong [this message]
2006-02-23 13:56 ` Alasdair G Kergon
2006-02-23 18:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140655617.3300.14.camel@localhost.localdomain \
--to=djwong@us.ibm.com \
--cc=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=dm-devel@redhat.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).