From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Andrew Morton <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kenneth.w.chen@intel.com,
"yanmin.zhang@intel.com" <yanmin.zhang@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
William Lee Irwin III <wli@holomorphy.com>,
Paul Mundt <lethal@linux-sh.org>,
kkojima@rr.iij4u.or.jp, "Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH] Enable mprotect on huge pages
Date: Mon, 27 Feb 2006 13:36:32 +0800 [thread overview]
Message-ID: <1141018592.1256.37.camel@ymzhang-perf.sh.intel.com> (raw)
In-Reply-To: <20060226230903.GA24422@localhost.localdomain>
On Mon, 2006-02-27 at 07:09, David Gibson wrote:
> On Fri, Feb 24, 2006 at 02:28:44PM -0800, Andrew Morton wrote:
> > "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> wrote:
> > >
> > > From: Zhang, Yanmin <yanmin.zhang@intel.com>
> > >
> > > 2.6.16-rc3 uses hugetlb on-demand paging, but it doesn_t support hugetlb
> > > mprotect. My patch against 2.6.16-rc3 enables this capability.
> > >
> >
> > Well I suppose that makes sense. It does assume that the normal pte
> > protection-changing APIs do the right thing on all architectures which
> > implement huge pages. That's quite possibly the case, but we should
> > confirm that.
>
> Well, it will need to be huge_ptep_get_and_clear() below, not the
> normal version.
I will change it.
> But pte_modify should be ok. I'm not sure
> pte_present() is safe, either, !pte_none() is what we use elsewhere in
> hugetlb.c.
pte_present is used in some files while !pte_none is used
in other files. Anyway, I will change it to !pte_none.
>
> And.. looks like lazy_mmu_prot_update() is unsafe, too. The only arch
> which has something here (ia64) has a function which does icache
> flushes on PAGE_SIZE only.
I already sent another patch to ia64 maillist to fix the issue.
See http://marc.theaimsgroup.com/?l=linux-ia64&m=114066414720468&w=2
Thanks.
next prev parent reply other threads:[~2006-02-27 5:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 3:19 [PATCH] Enable mprotect on huge pages Zhang, Yanmin
2006-02-24 22:28 ` Andrew Morton
2006-02-26 23:09 ` David Gibson
2006-02-27 5:36 ` Zhang, Yanmin [this message]
2006-02-27 6:33 ` Zhang, Yanmin
2006-02-28 1:34 ` Andrew Morton
2006-02-28 3:23 ` Zhang, Yanmin
2006-02-28 3:32 ` David Gibson
2006-02-28 3:37 ` Zhang, Yanmin
2006-02-28 8:24 ` David Gibson
2006-02-27 7:26 ` David Gibson
2006-02-25 8:54 ` Christoph Hellwig
2006-02-25 10:08 ` [2.4.32 - 2.6.15.4] e1000 - Fix mii interface Paul Rolland
2006-02-26 10:42 ` Willy TARREAU
2006-02-26 11:39 ` Paul Rolland
2006-02-26 12:59 ` Jesper Juhl
2006-02-26 14:55 ` Paul Rolland
2006-02-26 15:00 ` Jesper Juhl
2006-02-26 15:12 ` Paul Rolland
2006-02-27 19:26 ` Jesse Brandeburg
[not found] ` <4807377b0602271234v4b6cdeecpbcf8d4a6ac51cd20@mail.gmail.com>
2006-02-28 2:31 ` Jesse Brandeburg
2006-02-28 10:46 ` Paul Rolland
2006-02-27 5:09 ` [PATCH] Enable mprotect on huge pages Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141018592.1256.37.camel@ymzhang-perf.sh.intel.com \
--to=yanmin_zhang@linux.intel.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=david@gibson.dropbear.id.au \
--cc=kenneth.w.chen@intel.com \
--cc=kkojima@rr.iij4u.or.jp \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tony.luck@intel.com \
--cc=wli@holomorphy.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).