On Wed, 2006-04-05 at 21:21 +0800, Yi Yang wrote: > > +static void cleanup_dead_listener(listener * x) > +{ > + pid_filter * p = NULL, * pq = NULL; > + uid_filter * u = NULL, * uq = NULL; > + gid_filter * g = NULL, * gq = NULL; > + > + if (p == NULL) > + return; > I think you ment "if (x == NULL)" here. Otherwise, the condition will always be true. btw, I'm not reviewing your code, just stumbled across this while reading it.