linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: rafael.j.wysocki@intel.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	trong@android.com, Greg KH <gregkh@linuxfoundation.org>,
	swboyd@chromium.org, kaleshsingh@google.com
Subject: Regression with PM / wakeup: Show wakeup sources stats in sysfs"
Date: Thu, 28 May 2020 13:46:10 -0700	[thread overview]
Message-ID: <11459cde-7f57-c95b-8cac-4301f0a2390e@gmail.com> (raw)

Hi,

Commit c8377adfa78103be5380200eb9dab764d7ca890e ("PM / wakeup: Show
wakeup sources stats in sysfs") is causing some of our tests to fail
because /sys/class/net/*/device/power/wakeup_count is now 0, despite
/sys/kernel/debug/wakeup_sources clearly indicating that the Ethernet
device was responsible for system wake-up.

What's more in looking at /sys/class/wakekup/wakeup2/event_count, we
have the number of Wake-on-LAN wakeups recorded properly, but
wakeup_count is desperately 0, why is that?

This is seen on 5.4.43, but it is reproducible on Linus' master as well.

The Ethernet driver being used is under
drivers/net/ethernet/broadcom/genet/ and the relevant part is in the
function bcmgenet_set_wol().

BTW, I think you want to backport
e976eb4b91e906f20ec25b20c152d53c472fc3fd ("PM: wakeup: Show statistics
for deleted wakeup sources again") into 5.4 and 4.19 at least.

Thank you!
--
Florian

             reply	other threads:[~2020-05-28 20:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 20:46 Florian Fainelli [this message]
2020-05-29 16:51 ` Regression with PM / wakeup: Show wakeup sources stats in sysfs" Rafael J. Wysocki
2020-05-29 22:28   ` Tri Vo
2020-05-29 22:37     ` Florian Fainelli
2020-05-29 23:14       ` Tri Vo
2020-05-30 18:52         ` Florian Fainelli
2020-05-30 22:33           ` Tri Vo
2020-06-02  1:30             ` Florian Fainelli
2020-06-02  3:06               ` Florian Fainelli
2020-06-05 14:35                 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11459cde-7f57-c95b-8cac-4301f0a2390e@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kaleshsingh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=swboyd@chromium.org \
    --cc=trong@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).