From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970632AbdAELwj (ORCPT ); Thu, 5 Jan 2017 06:52:39 -0500 Received: from gloria.sntech.de ([95.129.55.99]:47595 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753855AbdAELwb (ORCPT ); Thu, 5 Jan 2017 06:52:31 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Shawn Lin Cc: Kishon Vijay Abraham I , Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Douglas Anderson , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Documentation: phy: introduce new optional property to specify drive impedance Date: Thu, 05 Jan 2017 12:15:18 +0100 Message-ID: <11505388.Y1Yzh8HsIT@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1483608682-226716-1-git-send-email-shawn.lin@rock-chips.com> References: <1483608682-226716-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Am Donnerstag, 5. Januar 2017, 17:31:21 schrieb Shawn Lin: > We need to modify the drive impedance according to the > different hardware condition. So let's expose this to > the DT. > > Signed-off-by: Shawn Lin > --- > > Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index > e3ea557..731aeb9 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > @@ -14,6 +14,11 @@ specified by name: > access to it), it is strongly suggested. > - clocks: Should have a phandle to the card clock exported by the SDHCI > driver. > > +Optional Properties: > +- drive_impedance: Must be one of 33, 40, 50, 66, 100. This property allows > + different boards to specify their own drive impedance depending on the > + hardware condition. In what unit are your 33, 40 etc values? It is recommended that properties should specify their unit, see all the properties ending in "-ma", "-ns" and so on and also Documentation/devicetree/bindings/property-units.txt Also properties should use dashes ("-") not underscores. Judging by the second patch, these are Ohm, so combining the above you probably want drive-impedance-ohms as property name. Also the patch subject is slightly misleading and should probably specify the rockchip-emmc as well :-) Heiko