From: Arjan van de Ven <arjan@infradead.org>
To: mgross@linux.intel.com
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, mark.gross@intel.com
Subject: Re: [PATCH] riport LADAR driver
Date: Mon, 26 Jun 2006 22:51:49 +0200 [thread overview]
Message-ID: <1151355109.3185.88.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060626205525.GA13411@linux.intel.com>
> +#define RIPORT_DEBUG
> +
> +#undef pr_debug
> +#ifdef RIPORT_DEBUG
> +# define pr_debug(fmt, args...) printk( KERN_DEBUG "riport: " fmt, ## args)
> +#else /* */
> +# define pr_debug(fmt, args...)
> +#endif /* */
ehhhhh that's not what I meant... if you would just remove these 6
lines.. then sure..
> + if (!request_region(io + ECP_OFFSET, 3, "riport")) {
> + release_region(io,3);
> +
> + pr_debug("request_region 0x%X of 3 bytes fails\n", io + ECP_OFFSET );
> + *presult = -EBUSY;
> + goto fail_io2;
this is a double release..
> +
> +fail_dev:
> + release_region(io + ECP_OFFSET,3);
> +fail_io2:
> + release_region(io,3);
with this.
> + current->state = TASK_RUNNING;
please use set_current_state() API for this
next prev parent reply other threads:[~2006-06-26 20:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 14:41 [PATCH] riport LADAR driver mark gross
2006-06-22 17:46 ` Randy.Dunlap
2006-06-22 18:20 ` Arjan van de Ven
2006-06-22 23:16 ` mark gross
2006-06-22 23:21 ` Randy.Dunlap
2006-06-23 5:52 ` Randy.Dunlap
2006-06-23 22:46 ` mark gross
2006-06-24 11:00 ` Arjan van de Ven
2006-06-26 20:55 ` mark gross
2006-06-26 20:51 ` Arjan van de Ven [this message]
2006-06-26 21:18 ` mark gross
2006-06-24 22:33 ` Randy.Dunlap
2006-06-24 12:48 Gross, Mark
2006-06-24 23:25 Gross, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151355109.3185.88.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=mgross@linux.intel.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).