From: David Howells <dhowells@redhat.com>
To: "Yan, Zheng" <zyan@redhat.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
linux-cachefs@redhat.com
Subject: Re: [PATCH] FS-Cache: make check_consistency callback return int
Date: Tue, 31 May 2016 21:36:42 +0100 [thread overview]
Message-ID: <11520.1464727002@warthog.procyon.org.uk> (raw)
In-Reply-To: <1463741639-5589-1-git-send-email-zyan@redhat.com>
Yan, Zheng <zyan@redhat.com> wrote:
> __fscache_check_consistency() calls check_consistency() callback
> and return the callback's return value. But the return type of
> check_consistency() is bool. So __fscache_check_consistency()
> return 1 if the cache is inconsistent. This is inconsistent with
> the document.
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2016-05-31 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 10:53 [PATCH] FS-Cache: make check_consistency callback return int Yan, Zheng
2016-05-31 20:36 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11520.1464727002@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).