From: Dave Hansen <haveblue@us.ibm.com>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
LSM ML <linux-security-module@vger.kernel.org>,
Dave Safford <safford@us.ibm.com>, Mimi Zohar <zohar@us.ibm.com>,
Serge Hallyn <sergeh@us.ibm.com>
Subject: Re: [RFC][PATCH 4/6] slim: secfs patch
Date: Fri, 14 Jul 2006 10:43:03 -0700 [thread overview]
Message-ID: <1152898983.314.9.camel@localhost.localdomain> (raw)
In-Reply-To: <1152897882.23584.7.camel@localhost.localdomain>
On Fri, 2006-07-14 at 10:24 -0700, Kylene Jo Hall wrote:
>
> +static ssize_t slm_read_level(struct file *file, char __user *buf,
> + size_t buflen, loff_t *ppos)
> +{
> + struct slm_tsec_data *cur_tsec = current->security;
> + ssize_t len;
> + char *page = (char *)__get_free_page(GFP_KERNEL);
Do you really need a page here? Why not just use kmalloc()?
-- Dave
next prev parent reply other threads:[~2006-07-14 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 17:24 [RFC][PATCH 4/6] slim: secfs patch Kylene Jo Hall
2006-07-14 17:43 ` Dave Hansen [this message]
2006-07-24 17:51 Kylene Jo Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152898983.314.9.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=safford@us.ibm.com \
--cc=sergeh@us.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).