From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net, blizzard@redhat.com,
dwmw2@redhat.com
Subject: Re: [PATCH 2/4] [PATCH] gxfb: Fixups for the AMD Geode GX framebuffer driver
Date: Wed, 26 Jul 2006 00:48:10 +0100 [thread overview]
Message-ID: <1153871290.7559.21.camel@localhost> (raw)
In-Reply-To: <20060724165602.18822.56823.stgit@cosmic.amd.com>
On Llu, 2006-07-24 at 10:56 -0600, Jordan Crouse wrote:
> +#ifdef CONFIG_FB_GEODE_GX_SET_FBSIZE
> +unsigned int gx_frame_buffer_size(void) {
> + return CONFIG_FB_GEODE_GX_FBSIZE;
> +}
> +#else
> unsigned int gx_frame_buffer_size(void)
> {
> unsigned int val;
> @@ -35,6 +40,7 @@ unsigned int gx_frame_buffer_size(void)
> val = (unsigned int)(inw(0xAC1E)) & 0xFFl;
> return (val << 19);
> }
> +#endif
GAK, please fix your firmware to follow your own docs 8). I mean while
VGA emulation is hard honouring the frame buffer size query is trivial
to stick in the GPL'd VSA firmware and belongs there.
next prev parent reply other threads:[~2006-07-25 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 16:54 [PATCH 0/4] OLPC + Geode GX framebuffer updates Jordan Crouse
2006-07-24 16:56 ` [PATCH 1/4] FB: Get the Geode GX frambuffer size from the BIOS Jordan Crouse
2006-07-24 16:56 ` [PATCH 2/4] [PATCH] gxfb: Fixups for the AMD Geode GX framebuffer driver Jordan Crouse
2006-07-25 23:48 ` Alan Cox [this message]
2006-07-24 16:56 ` [PATCH 3/4] [PATCH] gxfb: Support flat panel timings Jordan Crouse
2006-07-24 16:56 ` [PATCH 4/4] [PATCH] gxfb: Add timings for the OLPC LCD Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153871290.7559.21.camel@localhost \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=blizzard@redhat.com \
--cc=dwmw2@redhat.com \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).