From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Corentin Labbe <clabbe@baylibre.com>, pavel@ucw.cz, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: remove ide-disk trigger
Date: Tue, 29 Jun 2021 12:47:27 +0200 [thread overview]
Message-ID: <1153e311-e0cf-d869-e3f8-b679eb2e60de@metux.net> (raw)
In-Reply-To: <20210628191719.2823947-1-clabbe@baylibre.com>
On 28.06.21 21:17, Corentin Labbe wrote:
> diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c
> index 0741910785bb..38a5c21c0466 100644
> --- a/drivers/leds/trigger/ledtrig-disk.c
> +++ b/drivers/leds/trigger/ledtrig-disk.c
> @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void)
> led_trigger_register_simple("disk-activity", &ledtrig_disk);
> led_trigger_register_simple("disk-read", &ledtrig_disk_read);
> led_trigger_register_simple("disk-write", &ledtrig_disk_write);
> - led_trigger_register_simple("ide-disk", &ledtrig_ide);
>
> return 0;
> }
Shouldn't this line also be removed ?
DEFINE_LED_TRIGGER(ledtrig_ide);
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2021-06-29 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 19:17 [PATCH] leds: remove ide-disk trigger Corentin Labbe
2021-06-29 10:47 ` Enrico Weigelt, metux IT consult [this message]
2021-07-05 20:34 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153e311-e0cf-d869-e3f8-b679eb2e60de@metux.net \
--to=lkml@metux.net \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).