From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio/dac: ltc2632.txt
Date: Tue, 14 Apr 2020 10:33:34 +0800 [thread overview]
Message-ID: <1155e876-4e04-da0b-5fc4-78a1b8d3bb72@gtsys.com.hk> (raw)
In-Reply-To: <20200412120431.03631ea8@archlinux>
Jonathan,
On 12/4/2020 7:05 pm, Jonathan Cameron wrote:
> On Wed, 8 Apr 2020 16:10:24 +0800
> Chris Ruehl <chris.ruehl@gtsys.com.hk> wrote:
>
>> This patch add support for Analog Devices (Linear Technology)
>> LTC26234 Quad 12-/10-/8-Bit Rail-to-Rail DAC.
>> Update ltc2632.txt with the expansions for it.
>>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> Looks fine.
>
> We need to convert this over to yaml at somepoint. If you are feeling
> particularly generous and want to do it would be much appreciated but
> it certainly isn't a requirement just to add IDs :)
>
> thanks,
>
> jonathan
No concerns about conversion, I had a typo in the description.
LTC26234 is LTC2634 :) let me make a v2 and make the conversion.
Cheers.
>
>> ---
>> Documentation/devicetree/bindings/iio/dac/ltc2632.txt | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
>> index 338c3220f01a..1ab9570cf219 100644
>> --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
>> +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt
>> @@ -1,4 +1,4 @@
>> -Linear Technology LTC2632/2636 DAC
>> +Linear Technology LTC2632/2634/2636 DAC
>>
>> Required properties:
>> - compatible: Has to contain one of the following:
>> @@ -8,6 +8,12 @@ Required properties:
>> lltc,ltc2632-h12
>> lltc,ltc2632-h10
>> lltc,ltc2632-h8
>> + lltc,ltc2634-l12
>> + lltc,ltc2634-l10
>> + lltc,ltc2634-l8
>> + lltc,ltc2634-h12
>> + lltc,ltc2634-h10
>> + lltc,ltc2634-h8
>> lltc,ltc2636-l12
>> lltc,ltc2636-l10
>> lltc,ltc2636-l8
>
--
GTSYS Limited RFID Technology
9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2,
42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong
Tel (852) 9079 9521
Disclaimer: https://www.gtsys.com.hk/email/classified.html
prev parent reply other threads:[~2020-04-14 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 8:10 [PATCH 2/2] dt-bindings: iio/dac: ltc2632.txt Chris Ruehl
2020-04-12 11:05 ` Jonathan Cameron
2020-04-14 2:33 ` Chris Ruehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155e876-4e04-da0b-5fc4-78a1b8d3bb72@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).