From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com,
paulus@ozlabs.org, mpe@ellerman.id.au
Subject: Re: [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index
Date: Sat, 16 Jul 2016 03:02:36 +0200 [thread overview]
Message-ID: <11588667.R3ZLC4VYDO@vostro.rjw.lan> (raw)
In-Reply-To: <20160711184753.GD4695@ubuntu>
On Monday, July 11, 2016 11:47:53 AM Viresh Kumar wrote:
> On 30-06-16, 11:53, Akshay Adiga wrote:
> > Refactoring code to use frequency table index instead of pstate_id.
> > This abstraction will make the code independent of the pstate values.
> >
> > - No functional changes
> > - The highest frequency is at frequency table index 0 and the frequency
> > decreases as the index increases.
> > - Macros pstates_to_idx() and idx_to_pstate() can be used for conversion
> > between pstate_id and index.
> > - powernv_pstate_info now contains frequency table index to min, max and
> > nominal frequency (instead of pstate_ids)
> > - global_pstate_info new stores index values instead pstate ids.
> > - variables renamed as *_idx which now store index instead of pstate
> >
> > Signed-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>
> > Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> > ---
> > Changes from v1:
> > - changed macro names from get_pstate()/ get_index() to
> > idx_to_pstate()/ pstate_to_idx()
> > - Renamed variables that store index instead of pstate_id to *_idx
> > - Retained previous printk's
> >
> > v1 : http://marc.info/?l=linux-pm&m=146677701501225&w=1
> >
> > drivers/cpufreq/powernv-cpufreq.c | 177 ++++++++++++++++++++++----------------
> > 1 file changed, 102 insertions(+), 75 deletions(-)
>
> Haven't done in-depth review, but I trust that Gautham has done it :)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
prev parent reply other threads:[~2016-07-16 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 6:23 [PATCH v2] cpufreq: powernv: Replacing pstate_id with frequency table index Akshay Adiga
2016-07-07 4:12 ` Akshay Adiga
2016-07-11 18:47 ` Viresh Kumar
2016-07-16 1:02 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11588667.R3ZLC4VYDO@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).