From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Feng Kan <fkan@apm.com>, patches <patches@apm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] mailbox: add ACPI support for mailbox framework
Date: Tue, 07 Apr 2015 13:37:56 +0200 [thread overview]
Message-ID: <11619620.g1RKbURH6u@vostro.rjw.lan> (raw)
In-Reply-To: <20150407084143.GP17830@lahna.fi.intel.com>
On Tuesday, April 07, 2015 11:41:43 AM Mika Westerberg wrote:
> On Thu, Apr 02, 2015 at 11:04:24AM -0700, Feng Kan wrote:
> > On Thu, Apr 2, 2015 at 2:07 AM, Mika Westerberg
> > <mika.westerberg@linux.intel.com> wrote:
> > > On Wed, Apr 01, 2015 at 10:01:45AM -0700, Feng Kan wrote:
> > >> On Wed, Apr 1, 2015 at 12:45 AM, Mika Westerberg
> > >> <mika.westerberg@linux.intel.com> wrote:
> > >> > On Tue, Mar 31, 2015 at 02:18:00PM -0700, Feng Kan wrote:
> > >> >> This will add support for ACPI parsing of the mboxes attribute
> > >> >> when booting with ACPI table. The client will have a attribute
> > >> >> mimic the dts call "mboxes". In the ACPI case, the client will
> > >> >> mark "mboxes" with the ACPI HID of the mbox it wishes to use.
> > >> >>
> > >> >> Name (_DSD, Package () {
> > >> >> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > >> >> Package () {
> > >> >> Package (2) {"mboxes", "ACPIHID"},
> > >> >> }
> > >> >> })
> > >> >
> > >> > Instead of this, why not match against the DT compatible property?
> > >> >
> > >> > Name (_HID, "PRP0001")
> > >> >
> > >> > Name (_DSD, Package () {
> > >> > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > >> > Package () {
> > >> > Package (2) {"compatible", "your-dt-compatible-string"},
> > >> > }
> > >> > })
> > >> I think my description was not clear enough. The _DSD section is not
> > >> meant to identify the mailbox driver, but used by the acpi node that will
> > >> request the mailbox channel. The dts version would be as below.
> > >>
> > >> mailbox: {
> > >> }
> > >>
> > >> user-mbox: {
> > >> mboxes: <&mailbox 0>
> > >> }
> > >>
> > >> The mboxes attribute in the user of the mbox has to specify the HID of the
> > >> mbox in order to retrieve channel pointer.
> > >
> > > Okay, then I think you can use reference instead of _HID, like
> > >
> > > // The mailbox device
> > > Device (MLBX) {
> > > }
> > >
> > > // User-mbox device
> > > Device (USBX) {
> > > Name (_DSD, Package () {
> > > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > Package () {
> > > Package () {"mboxes", Package () {^^MLBX, 0}}),
> > > }
> > > })
> > > }
> >
> > Thanks, will try this. A side question on your previous reply. Would you
> > prefer a new driver using the PRP0001 or an actual proper HID.
>
> If you have existing DT bindings for this, then PRP0001 is fine.
> Otherwise you should use the proper _HID for this particular device.
To be precise, PRP0001 specifically means "Use the 'compatible' property
to find the driver for this device", so if *that* is what you want to do,
you can use PRP0001 as the _HID. For Windows (and such) compatibility, you
can provide a _CID whith a (list of) proper device ID(s) in addition to that.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-04-07 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 21:18 [PATCH] mailbox: add ACPI support for mailbox framework Feng Kan
2015-04-01 7:45 ` Mika Westerberg
2015-04-01 17:01 ` Feng Kan
2015-04-02 9:07 ` Mika Westerberg
2015-04-02 18:04 ` Feng Kan
2015-04-07 8:41 ` Mika Westerberg
2015-04-07 11:37 ` Rafael J. Wysocki [this message]
2015-04-07 14:05 ` Mika Westerberg
2015-04-07 22:58 ` Feng Kan
2015-04-10 23:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11619620.g1RKbURH6u@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=fkan@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).