archive mirror
 help / color / mirror / Atom feed
From: James Smart <>
To: Kees Cook <>,
	James Smart <>
Cc: Dick Kennedy <>,
	"James E.J. Bottomley" <>,
	"Martin K. Petersen" <>,,,
Subject: Re: [PATCH] scsi: lpfc: Use struct_group() to initialize struct lpfc_cgn_info
Date: Thu, 9 Dec 2021 06:50:43 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 12/8/2021 11:59 AM, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memset(), avoid intentionally writing across
> neighboring fields.
> Add struct_group() to mark "stat" region of struct lpfc_cgn_info that
> should be initialized to zero, and refactor the "data" region memset()
> to wipe everything up to the cgn_stats region.
> Signed-off-by: Kees Cook <>
> ---

looks fine.

Reviewed-by: James Smart <>

-- james

  reply	other threads:[~2021-12-09 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 19:59 [PATCH] scsi: lpfc: Use struct_group() to initialize struct lpfc_cgn_info Kees Cook
2021-12-09 14:50 ` James Smart [this message]
2021-12-14  4:31 ` Martin K. Petersen
2021-12-17  4:04 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).