From: Steve Wise <swise@opengridcomputing.com>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: netdev@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH v4 01/13] Linux RDMA Core Changes
Date: Wed, 03 Jan 2007 14:20:18 -0600 [thread overview]
Message-ID: <1167855618.4187.65.camel@stevo-desktop> (raw)
In-Reply-To: <20070103193324.GD29003@mellanox.co.il>
On Wed, 2007-01-03 at 21:33 +0200, Michael S. Tsirkin wrote:
> > Without extra param (1000 iterations in cycles):
> > ave 101.283 min 91 max 247
> > With extra param (1000 iterations in cycles):
> > ave 103.311 min 91 max 221
>
> A 2% hit then. Not huge, but 0 either.
>
> > Convert cycles to ns (3466.727 MHz CPU):
> >
> > Without: 101.283 / 3466.727 = .02922us == 29.22ns
> > With: 103.311 / 3466.727 = .02980us == 29.80ns
> >
> > So I measure a .58ns average increase for passing in the additional
> > parameter.
>
> That depends on CPU speed though. Percentage is likely to be more universal.
>
> > Here is a snipit of the test:
> >
> > spin_lock_irq(&lock);
> > do_gettimeofday(&start_tv);
> > for (i=0; i<1000; i++) {
> > cycles_start[i] = get_cycles();
> > ib_req_notify_cq(cb->cq, IB_CQ_NEXT_COMP);
> > cycles_stop[i] = get_cycles();
> > }
> > do_gettimeofday(&stop_tv);
> > spin_unlock_irq(&lock);
> >
> > if (stop_tv.tv_usec < start_tv.tv_usec) {
> > stop_tv.tv_usec += 1000000;
> > stop_tv.tv_sec -= 1;
> > }
> >
> > for (i=0; i < 1000; i++) {
> > cycles_t v = cycles_stop[i] - cycles_start[i];
> > sum += v;
> > if (v > max)
> > max = v;
> > if (min == 0 || v < min)
> > min = v;
> > }
> >
> > printk(KERN_ERR PFX "FOO delta sec %lu usec %lu sum %llu min %llu max %llu\n",
> > stop_tv.tv_sec - start_tv.tv_sec,
> > stop_tv.tv_usec - start_tv.tv_usec,
> > (unsigned long long)sum, (unsigned long long)min,
> > (unsigned long long)max);
>
> Good job, the test looks good, thanks.
>
> So what does this tell you?
> To me it looks like there's a measurable speed difference,
> and so we should find a way (e.g. what I proposed) to enable chelsio userspace
> without adding overhead to other low level drivers or indeed chelsio kernel level code.
>
> What do you think? Roland?
>
I think having a 2nd function to set the udata seems onerous.
next prev parent reply other threads:[~2007-01-03 20:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 13:52 [PATCH v4 00/13] 2.6.20 Chelsio T3 RDMA Driver Steve Wise
2006-12-14 13:53 ` [PATCH v4 01/13] Linux RDMA Core Changes Steve Wise
2006-12-24 8:49 ` Michael S. Tsirkin
2007-01-03 14:25 ` Steve Wise
2007-01-03 14:41 ` Michael S. Tsirkin
2007-01-03 14:56 ` Steve Wise
2007-01-03 15:00 ` Michael S. Tsirkin
2007-01-03 15:07 ` Steve Wise
2007-01-03 15:18 ` Michael S. Tsirkin
2007-01-03 19:17 ` Steve Wise
2007-01-03 19:33 ` Michael S. Tsirkin
2007-01-03 20:20 ` Steve Wise [this message]
2007-01-03 21:22 ` [openib-general] " Steve Wise
2007-01-04 5:07 ` Michael S. Tsirkin
2007-01-04 14:07 ` Steve Wise
2007-01-04 21:34 ` [openib-general] " Roland Dreier
2007-01-04 21:49 ` Steve Wise
2007-01-05 14:22 ` Steve Wise
2007-01-03 15:02 ` Michael S. Tsirkin
2007-01-03 15:06 ` Steve Wise
2007-01-03 15:10 ` Michael S. Tsirkin
2006-12-14 13:53 ` [PATCH v4 02/13] Device Discovery and ULLD Linkage Steve Wise
2006-12-14 13:54 ` [PATCH v4 03/13] Provider Methods and Data Structures Steve Wise
2006-12-14 13:54 ` [PATCH v4 04/13] Connection Manager Steve Wise
2006-12-14 13:55 ` [PATCH v4 05/13] Queue Pairs Steve Wise
2006-12-14 13:55 ` [PATCH v4 06/13] Completion Queues Steve Wise
2006-12-14 13:56 ` [PATCH v4 07/13] Async Event Handler Steve Wise
2006-12-14 13:56 ` [PATCH v4 08/13] Memory Registration Steve Wise
2006-12-14 13:57 ` [PATCH v4 09/13] Core WQE/CQE Types Steve Wise
2006-12-14 13:57 ` [PATCH v4 10/13] Core HAL Steve Wise
2006-12-14 13:58 ` [PATCH v4 11/13] Core Resource Allocation Steve Wise
2006-12-14 13:58 ` [PATCH v4 12/13] Core Debug functions Steve Wise
2006-12-14 13:59 ` [PATCH v4 13/13] Kconfig/Makefile Steve Wise
2007-01-05 17:32 [openib-general] [PATCH v4 01/13] Linux RDMA Core Changes Felix Marti
2007-01-06 17:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167855618.4187.65.camel@stevo-desktop \
--to=swise@opengridcomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).