linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Christoph Lameter <clameter@sgi.com>,
	Robert Hancock <hancockr@shaw.ca>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.20-rc3-git4 oops on suspend: __drain_pages
Date: Sun, 07 Jan 2007 20:34:10 -0200	[thread overview]
Message-ID: <1168209251.11528.34.camel@praia> (raw)
In-Reply-To: <84144f020701070833i19cbb179md5426ca4b4be371c@mail.gmail.com>

Em Dom, 2007-01-07 às 18:33 +0200, Pekka Enberg escreveu:
> On Thu, 4 Jan 2007, Robert Hancock wrote:
> > > > Saw this oops on 2.6.20-rc3-git4 when attempting to suspend. This only
> > > > happened in 1 of 3 attempts.
> 
> On Friday, 5 January 2007 20:15, Christoph Lameter wrote:
> > > See the fix that I posted yesterday to linux-mm. Its now in Andrew's tree.
> 
> On 1/5/07, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > I can't find it in -mm.
> >
> > Could you please post it here?
> 
> I think it's this:
> 
> http://marc.theaimsgroup.com/?l=linux-mm&m=116793590117896&w=2

This fixed for me too with kernel 2.6.19.1. On my machine, every second
trial to unplug the second CPU core were generating OOPS, and breaking
hibernation. I've opened a bugzilla (#7786).

There is a remain stuff to be fixed, related to cpuhotplug: kernel with
debug options enabled shows that there is a circular locking dependency
(http://bugzilla.kernel.org/attachment.cgi?id=10020&action=view):

 =======================================================
[ INFO: possible circular locking dependency detected ]
2.6.19.1 #1
-------------------------------------------------------
stress/5670 is trying to acquire lock:
 (cpu_bitmask_lock){--..}, at: [<ffffffff8015af7d>] lock_cpu_hotplug+0x6d/0x80

but task is already holding lock:
 (workqueue_mutex){--..}, at: [<ffffffff8014962f>] workqueue_cpu_callback+0x16f/0x2d0

which lock already depends on the new lock.

This happens the first time I do:

echo 0 >/sys/devices/system/cpu/cpu1/online

on an AMD/64 dual core.

It would be interesting to have this patch also applied to -stable.

Cheers, 
Mauro.


      reply	other threads:[~2007-01-07 22:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-05  1:59 2.6.20-rc3-git4 oops on suspend: __drain_pages Robert Hancock
2007-01-05 17:34 ` Pavel Machek
2007-01-05 19:15 ` Christoph Lameter
2007-01-05 19:36   ` Rafael J. Wysocki
2007-01-07 16:33     ` Pekka Enberg
2007-01-07 22:34       ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1168209251.11528.34.camel@praia \
    --to=mchehab@infradead.org \
    --cc=clameter@sgi.com \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).