From: Richard Purdie <rpurdie@rpsys.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Németh Márton" <nm127@freemail.hu>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: extend EV_LED
Date: Thu, 15 Feb 2007 23:36:04 +0000 [thread overview]
Message-ID: <1171582564.5839.44.camel@localhost.localdomain> (raw)
In-Reply-To: <20070215232438.GB4176@elf.ucw.cz>
On Fri, 2007-02-16 at 00:24 +0100, Pavel Machek wrote:
> > The led framework is generic. If you can write a function to turn it
> > on/off you can drive it with the LED framework.
>
> Even if that function is slow and sleeps?
The LED class itself can call in interrupt context so you'd have to
schedule a workqueue if you need to sleep.
> > One way I've come up with is adds capability to the class to have LED
> > specific triggers and you can then expose these hardware capabilities as
> > an extra trigger specific to the LED.
> >
> > Another proposal more specific to this use case was to have some
> > information behind the scenes which the software timer based trigger
> > could use to turn on the "hardware acceleration" if present and capable
> > of the requested mode. This might just need a function pointer in the
> > core so could be quite neat.
>
> I do not think we want to permit this led to run in "not accelerated"
> mode. I believe i8042 accesses are pretty expensive.
Which means they probably won't work well with the standard triggers.
Not something we can do much about though...
> > Nether patch exists yet.
>
> Yep, interested party should create one of them :-). (And I'd prefer
> the first one, due to i8042 slowness).
Right, patches welcome :)
Cheers,
Richard
next prev parent reply other threads:[~2007-02-15 23:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 10:02 [PATCH] input: extend EV_LED Németh Márton
2007-02-12 18:31 ` Dmitry Torokhov
2007-02-14 19:06 ` Németh Márton
2007-02-14 19:49 ` Dmitry Torokhov
2007-02-14 23:51 ` Németh Márton
2007-02-15 17:40 ` Pavel Machek
2007-02-15 22:47 ` Németh Márton
2007-02-15 23:09 ` Richard Purdie
2007-02-15 23:24 ` Pavel Machek
2007-02-15 23:36 ` Richard Purdie [this message]
2007-02-16 3:12 ` Henrique de Moraes Holschuh
2007-02-18 11:05 ` Richard Purdie
2007-02-18 14:42 ` Henrique de Moraes Holschuh
2007-02-18 7:45 ` Németh Márton
2007-02-18 8:07 ` Willy Tarreau
2007-02-18 11:12 ` Richard Purdie
2007-02-16 14:04 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171582564.5839.44.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).