From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85608C433E0 for ; Sun, 26 Jul 2020 17:15:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66C812065F for ; Sun, 26 Jul 2020 17:15:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgGZRPg (ORCPT ); Sun, 26 Jul 2020 13:15:36 -0400 Received: from smtprelay0146.hostedemail.com ([216.40.44.146]:56558 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726121AbgGZRPg (ORCPT ); Sun, 26 Jul 2020 13:15:36 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id F15A5182CED5B; Sun, 26 Jul 2020 17:15:34 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sound58_281484c26f5a X-Filterd-Recvd-Size: 1982 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Sun, 26 Jul 2020 17:15:33 +0000 (UTC) Message-ID: <1177f80aa848a294f65e305729304b76d1e5ee98.camel@perches.com> Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations From: Joe Perches To: Greg KH , Aditya Jain Cc: devel@driverdev.osuosl.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Date: Sun, 26 Jul 2020 10:15:32 -0700 In-Reply-To: <20200726150244.GD452766@kroah.com> References: <20200726141831.2662-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-3-aditya.jainadityajain.jain@gmail.com> <20200726150244.GD452766@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote: > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > > Cleaning up messy multiline function declarations in hal_phy_cfg.h [] > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h [] > > -void > > -PHY_SetSwChnlBWMode8723B( > > -struct adapter *Adapter, > > -u8 channel, > > -enum CHANNEL_WIDTH Bandwidth, > > -u8 Offset40, > > -u8 Offset80 > > +void PHY_SetBWMode8723B(struct adapter *Adapter, > > + enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > > + unsigned char Offset /* Upper, Lower, or Don't care */ > > Those comments should go at the top of the function declaration, in > kernel doc format. Not every external function needs kernel-doc. This is a realtek staging driver that likely it will never be moved out of staging.