From: "J, KEERTHY" <j-keerthy@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<robh+dt@kernel.org>, <daniel.lezcano@linaro.org>,
<rui.zhang@intel.com>, <amitk@kernel.org>, <kristo@kernel.org>,
<vigneshr@ti.com>
Cc: <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation
Date: Wed, 11 May 2022 13:23:27 +0530 [thread overview]
Message-ID: <117f175f-62d1-17b5-742b-bcb250b7866f@ti.com> (raw)
In-Reply-To: <eb0745a6-ecf2-4b70-368b-9ad8a322f208@linaro.org>
On 5/9/2022 12:12 PM, Krzysztof Kozlowski wrote:
> On 09/05/2022 05:18, J, KEERTHY wrote:
>>
>>
>> On 4/27/2022 12:16 PM, Keerthy wrote:
>>> Add VTM bindings documentation. In the Voltage Thermal
>>> Management Module(VTM), K3 J72XX supplies a voltage
>>> reference and a temperature sensor feature that are gathered in the band
>>> gap voltage and temperature sensor (VBGAPTS) module. The band
>>> gap provides current and voltage reference for its internal
>>> circuits and other analog IP blocks. The analog-to-digital
>>> converter (ADC) produces an output value that is proportional
>>> to the silicon temperature.
>>
>> Hi krzysztof,
>>
>> Any comments on this version?
>
> You got Rob's review, so you don't need also mine.
>
> If you want, then in general look okay, except the description for "reg"
> you could split per items:
>
> reg:
> items:
> - description: VTM cfg1 register space
> - description: VTM cfg2 register space
> - description: efuse register space
>
> It's more obvious what items you expect.
Hi Krzysztof,
DTEX
Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts
Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml: found
duplicate key "description" with value "VTM cfg2 register space"
(original value: "VTM cfg1 register space")
Documentation/devicetree/bindings/Makefile:26: recipe for target
'Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts'
failed
make[1]: ***
[Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts] Er
I believe multiple instances of description is failing. So can i keep
the description as is?
- Keerthy
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-05-11 7:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:46 [PATCH v6 0/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-04-27 6:46 ` [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Keerthy
2022-05-03 0:34 ` Rob Herring
2022-05-09 3:18 ` J, KEERTHY
2022-05-09 6:42 ` Krzysztof Kozlowski
2022-05-11 7:53 ` J, KEERTHY [this message]
2022-05-11 8:15 ` Krzysztof Kozlowski
2022-05-11 10:57 ` J, KEERTHY
2022-04-27 6:46 ` [PATCH v6 2/4] arm64: dts: ti: j721e: Add VTM node Keerthy
2022-04-27 6:46 ` [PATCH v6 3/4] arm64: dts: ti: j7200: " Keerthy
2022-04-27 6:46 ` [PATCH v6 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-05-04 8:00 ` Dan Carpenter
2022-05-09 5:20 ` Joe Perches
2022-05-09 3:10 ` J, KEERTHY
2022-05-10 15:25 ` Daniel Lezcano
2022-05-10 17:17 ` J, KEERTHY
2022-05-10 17:38 ` Daniel Lezcano
2022-05-11 4:57 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=117f175f-62d1-17b5-742b-bcb250b7866f@ti.com \
--to=j-keerthy@ti.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).