From: 王贇 <yun.wang@linux.alibaba.com>
To: bsegall@google.com, Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mel Gorman <mgorman@suse.de>,
"open list:SCHEDULER" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] sched: fix the nonsense shares when load of cfs_rq is too, small
Date: Thu, 5 Mar 2020 09:14:47 +0800 [thread overview]
Message-ID: <1180c6cd-ff61-2c9f-d689-ffe58f8c5a68@linux.alibaba.com> (raw)
In-Reply-To: <xm26o8tc3qkv.fsf@bsegall-linux.svl.corp.google.com>
On 2020/3/5 上午2:47, bsegall@google.com wrote:
[snip]
>> Argh, because A->cfs_rq.load.weight is B->se.load.weight which is
>> B->shares/nr_cpus.
>>
>>> While the se of D on root cfs_rq is far more bigger than 2, so it
>>> wins the battle.
>>>
>>> This patch add a check on the zero load and make it as MIN_SHARES
>>> to fix the nonsense shares, after applied the group C wins as
>>> expected.
>>>
>>> Signed-off-by: Michael Wang <yun.wang@linux.alibaba.com>
>>> ---
>>> kernel/sched/fair.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>>> index 84594f8aeaf8..53d705f75fa4 100644
>>> --- a/kernel/sched/fair.c
>>> +++ b/kernel/sched/fair.c
>>> @@ -3182,6 +3182,8 @@ static long calc_group_shares(struct cfs_rq *cfs_rq)
>>> tg_shares = READ_ONCE(tg->shares);
>>>
>>> load = max(scale_load_down(cfs_rq->load.weight), cfs_rq->avg.load_avg);
>>> + if (!load && cfs_rq->load.weight)
>>> + load = MIN_SHARES;
>>>
>>> tg_weight = atomic_long_read(&tg->load_avg);
>>
>> Yeah, I suppose that'll do. Hurmph, wants a comment though.
>>
>> But that has me looking at other users of scale_load_down(), and doesn't
>> at least update_tg_cfs_load() suffer the same problem?
>
> I think instead we should probably scale_load_down(tg_shares) and
> scale_load(load_avg). tg_shares is always a scaled integer, so just
> moving the source of the scaling in the multiply should do the job.
>
> ie
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index fcc968669aea..6d7a9d72d742 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3179,9 +3179,9 @@ static long calc_group_shares(struct cfs_rq *cfs_rq)
> long tg_weight, tg_shares, load, shares;
> struct task_group *tg = cfs_rq->tg;
>
> - tg_shares = READ_ONCE(tg->shares);
> + tg_shares = scale_load_down(READ_ONCE(tg->shares));
>
> - load = max(scale_load_down(cfs_rq->load.weight), cfs_rq->avg.load_avg);
> + load = max(cfs_rq->load.weight, scale_load(cfs_rq->avg.load_avg));
>
> tg_weight = atomic_long_read(&tg->load_avg);
Get the point, but IMHO fix scale_load_down() sounds better, to
cover all the similar cases, let's first try that way see if it's
working :-)
Regards,
Michael Wang
>
>
>
next prev parent reply other threads:[~2020-03-05 1:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 14:17 [RFC PATCH] sched: fix the nonsense shares when load of cfs_rq is too, small 王贇
2020-03-03 19:52 ` Peter Zijlstra
2020-03-04 1:19 ` 王贇
2020-03-04 8:47 ` Vincent Guittot
2020-03-04 9:43 ` Vincent Guittot
2020-03-05 1:23 ` 王贇
2020-03-04 9:52 ` Peter Zijlstra
2020-03-04 11:55 ` Vincent Guittot
2020-03-05 1:08 ` 王贇
2020-03-04 8:45 ` Vincent Guittot
2020-03-04 18:47 ` bsegall
2020-03-05 1:14 ` 王贇 [this message]
2020-03-05 7:53 ` Vincent Guittot
2020-03-06 4:23 ` 王贇
2020-03-06 8:04 ` Vincent Guittot
2020-03-06 9:34 ` 王贇
2020-03-06 19:17 ` bsegall
2020-03-09 11:15 ` Vincent Guittot
2020-03-10 3:42 ` 王贇
2020-03-10 7:57 ` Vincent Guittot
2020-03-10 8:15 ` 王贇
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180c6cd-ff61-2c9f-d689-ffe58f8c5a68@linux.alibaba.com \
--to=yun.wang@linux.alibaba.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).