From: Dave McCracken <dmccr@us.ibm.com>
To: Andrew Morton <akpm@digeo.com>, Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Rising io_load results Re: 2.5.63-mm1
Date: Thu, 27 Feb 2003 16:01:13 -0600 [thread overview]
Message-ID: <118810000.1046383273@baldur.austin.ibm.com> (raw)
In-Reply-To: <20030227134403.776bf2e3.akpm@digeo.com>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
--On Thursday, February 27, 2003 13:44:03 -0800 Andrew Morton
<akpm@digeo.com> wrote:
>> ...
>> Mapped: 4294923652 kB
>
> Well that's gotta hurt. This metric is used in making writeback
> decisions. Probably the objrmap patch.
Oops. You're right. Here's a patch to fix it.
Dave McCracken
======================================================================
Dave McCracken IBM Linux Base Kernel Team 1-512-838-3059
dmccr@us.ibm.com T/L 678-3059
[-- Attachment #2: objmapped-2.5.63-1.diff --]
[-- Type: text/plain, Size: 337 bytes --]
--- 2.5.63-objrmap/mm/rmap.c 2003-02-27 15:58:34.000000000 -0600
+++ 2.5.63-objfix/mm/rmap.c 2003-02-27 15:56:56.000000000 -0600
@@ -248,6 +248,8 @@
BUG();
if (PageSwapCache(page))
BUG();
+ if (atomic_read(&page->pte.mapcount) == 0)
+ inc_page_state(nr_mapped);
atomic_inc(&page->pte.mapcount);
return pte_chain;
}
next prev parent reply other threads:[~2003-02-27 21:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-27 10:59 2.5.63-mm1 Andrew Morton
2003-02-27 21:22 ` Rising io_load results 2.5.63-mm1 Con Kolivas
2003-02-27 21:44 ` Andrew Morton
2003-02-27 22:01 ` Dave McCracken [this message]
2003-02-27 22:24 ` Andrew Morton
2003-03-03 21:06 ` [PATCH 2.5.63] Teach page_mapped about the anon flag Dave McCracken
2003-03-03 21:12 ` Andrew Morton
2003-03-03 21:24 ` Dave McCracken
2003-03-03 21:35 ` Andrew Morton
2003-03-03 21:52 ` Dave McCracken
2003-03-03 22:15 ` Andrew Morton
2003-03-04 18:32 ` [PATCH 2.5.63] Make objrmap mapcount non-atomic Dave McCracken
2003-02-27 23:56 ` Rising io_load results Re: 2.5.63-mm1 Con Kolivas
2003-02-28 0:06 ` Andrew Morton
2003-02-28 0:28 ` Con Kolivas
2003-02-28 7:46 ` Duncan Sands
2003-02-28 8:06 ` Andrew Morton
2003-02-28 12:48 ` Hugh Dickins
2003-02-28 15:56 ` Dave McCracken
2003-02-28 0:17 ` 2.5.63-mm1 Ed Tomlinson
2003-02-28 0:46 ` 2.5.63-mm1 Andrew Morton
2003-02-28 12:16 ` 2.5.63-mm1 steven roemen
2003-02-28 12:24 ` 2.5.63-mm1 Andrew Morton
[not found] ` <3E5F7DAD.2080306@cyberone.com.au>
[not found] ` <200302282227.56311.tomlins@cam.org>
2003-03-01 15:04 ` [PATCH] tiobench on UP and ptg-D3-mm1 Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118810000.1046383273@baldur.austin.ibm.com \
--to=dmccr@us.ibm.com \
--cc=akpm@digeo.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).