From: Julian Anastasov <ja@ssi.bg>
To: yangxingwu <xingwu.yang@gmail.com>
Cc: Simon Horman <horms@verge.net.au>,
Pablo Neira Ayuso <pablo@netfilter.org>,
kadlec@netfilter.org, fw@strlen.de,
"David S. Miller" <davem@davemloft.net>,
kuba@kernel.org, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, corbet@lwn.net
Subject: Re: [PATCH] ipvs: Fix reuse connection if RS weight is 0
Date: Tue, 26 Oct 2021 08:44:28 +0300 (EEST) [thread overview]
Message-ID: <1190ef60-3ad9-119e-5336-1c62522aec81@ssi.bg> (raw)
In-Reply-To: <CA+7U5JsSuwqP7eHj1tMHfsb+EemwrhZEJ2b944LFWTroxAnQRQ@mail.gmail.com>
Hello,
On Tue, 26 Oct 2021, yangxingwu wrote:
> thanks julian
>
> What happens in this situation is that if we set the wait of the
> realserver to 0 and do NOT remove the weight zero realserver with
> sysctl settings (conn_reuse_mode == 0 && expire_nodest_conn == 1), and
> the client reuses its source ports, the kernel will constantly
> reuse connections and send the traffic to the weight 0 realserver.
Yes, this is expected when conn_reuse_mode=0.
> you may check the details from
> https://github.com/kubernetes/kubernetes/issues/81775
What happens if you try conn_reuse_mode=1? The
one-second delay in previous kernels should be corrected with
commit f0a5e4d7a594e0fe237d3dfafb069bb82f80f42f
Date: Wed Jul 1 18:17:19 2020 +0300
ipvs: allow connection reuse for unconfirmed conntrack
> On Tue, Oct 26, 2021 at 2:12 AM Julian Anastasov <ja@ssi.bg> wrote:
> >
> > On Mon, 25 Oct 2021, yangxingwu wrote:
> >
> > > Since commit dc7b3eb900aa ("ipvs: Fix reuse connection if real server is
> > > dead"), new connections to dead servers are redistributed immediately to
> > > new servers.
> > >
> > > Then commit d752c3645717 ("ipvs: allow rescheduling of new connections when
> > > port reuse is detected") disable expire_nodest_conn if conn_reuse_mode is
> > > 0. And new connection may be distributed to a real server with weight 0.
> >
> > Your change does not look correct to me. At the time
> > expire_nodest_conn was created, it was not checked when
> > weight is 0. At different places different terms are used
> > but in short, we have two independent states for real server:
> >
> > - inhibited: weight=0 and no new connections should be served,
> > packets for existing connections can be routed to server
> > if it is still available and packets are not dropped
> > by expire_nodest_conn.
> > The new feature is that port reuse detection can
> > redirect the new TCP connection into a new IPVS conn and
> > to expire the existing cp/ct.
> >
> > - unavailable (!IP_VS_DEST_F_AVAILABLE): server is removed,
> > can be temporary, drop traffic for existing connections
> > but on expire_nodest_conn we can select different server
> >
> > The new conn_reuse_mode flag allows port reuse to
> > be detected. Only then expire_nodest_conn has the
> > opportunity with commit dc7b3eb900aa to check weight=0
> > and to consider the old traffic as finished. If a new
> > server is selected, any retrans from previous connection
> > would be considered as part from the new connection. It
> > is a rapid way to switch server without checking with
> > is_new_conn_expected() because we can not have many
> > conns/conntracks to different servers.
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2021-10-26 5:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 11:59 [PATCH] ipvs: Fix reuse connection if RS weight is 0 yangxingwu
2021-10-25 18:12 ` Julian Anastasov
2021-10-26 2:54 ` yangxingwu
2021-10-26 5:44 ` Julian Anastasov [this message]
2021-10-26 6:13 ` yangxingwu
2021-10-27 1:43 ` yangxingwu
2021-10-27 21:09 ` Julian Anastasov
2021-10-28 2:50 ` yangxingwu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190ef60-3ad9-119e-5336-1c62522aec81@ssi.bg \
--to=ja@ssi.bg \
--cc=corbet@lwn.net \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xingwu.yang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).