From: Stefan Wahren <stefan.wahren@i2se.com>
To: Helen Koike <helen.koike@collabora.com>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
lkundrak@v3.sk, bcm-kernel-feedback-list@broadcom.com,
eric@anholt.net, devicetree@vger.kernel.org,
kernel@collabora.com
Subject: Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Date: Mon, 4 Mar 2019 21:15:42 +0100 (CET) [thread overview]
Message-ID: <1194402400.301453.1551730542978@email.ionos.de> (raw)
In-Reply-To: <20190304185454.18043-1-helen.koike@collabora.com>
Hi Helen,
> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 19:54 geschrieben:
>
>
> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.
thanks for your report and the patch. I verified your change against dt-blob.dts / downstream file and it's correct.
I'm sorry but i cannot apply your patch because it doesn't have the proper format.
Should i take care of this?
Can i add your Signed-off-by including your mail address?
Stefan
>
> Regards,
> Helen
>
> ---
> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> index 5641d162dfdb..28e7513ce617 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
> @@ -93,7 +93,7 @@
> };
>
> &hdmi {
> - hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
> + hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
> };
>
> &pwm {
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-03-04 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 18:54 rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Helen Koike
2019-03-04 20:15 ` Stefan Wahren [this message]
2019-03-04 21:52 ` Helen Koike
2019-03-04 20:27 ` Eric Anholt
2019-03-04 21:54 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194402400.301453.1551730542978@email.ionos.de \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=helen.koike@collabora.com \
--cc=kernel@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).