linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jengelh@computergmbh.de, randy.dunlap@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Reduce stack used by lib/hexdump.c
Date: Wed, 05 Dec 2007 18:10:16 -0800	[thread overview]
Message-ID: <1196907017.10819.49.camel@localhost> (raw)
In-Reply-To: <20071205160133.0766c4f5.akpm@linux-foundation.org>

On Wed, 2007-12-05 at 16:01 -0800, Andrew Morton wrote:
> You could trim linebuf[] to 80 chars or so.  Extra points for making it
> very clear when someone tries to exceed that - strcpy(linebuf, "stop being
> stupid").

Maybe just eliminate the 16 or 32 byte width option and
force it to only 16 byte widths.

That'd keep it down to ~ 100 bytes nicely.

Prefix + address + dump + ascii: 20 + 18 + 48 + 10.


  reply	other threads:[~2007-12-06  2:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 18:08 [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c Joe Perches
2007-11-29 18:24 ` Randy Dunlap
2007-11-29 18:44   ` Joe Perches
2007-11-29 18:52     ` Randy Dunlap
2007-11-29 18:55       ` Joe Perches
2007-11-29 20:57       ` [PATCH] Reduce stack used by lib/hexdump.c Joe Perches
2007-11-29 21:02         ` Randy Dunlap
2007-11-29 21:07           ` Jan Engelhardt
2007-11-29 23:28             ` Joe Perches
2007-12-06  0:01               ` Andrew Morton
2007-12-06  2:10                 ` Joe Perches [this message]
2007-12-06  2:18                   ` Randy Dunlap
2007-12-06  2:42                     ` Joe Perches
2007-12-06  5:58                       ` Kyle Moffett
2007-12-06  7:10                         ` Andrew Morton
2007-12-06 21:52                 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196907017.10819.49.camel@localhost \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).