From: Zach Brown <zach.brown@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Ulrich Drepper <drepper@redhat.com>,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@zip.com.au>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
"David S. Miller" <davem@davemloft.net>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Davide Libenzi <davidel@xmailserver.org>,
Jens Axboe <jens.axboe@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@gmail.com>,
Jeff Moyer <jmoyer@redhat.com>,
Simon Holm Thogersen <odie@cs.aau.dk>,
suresh.b.siddha@intel.com
Subject: [PATCH 1/6] indirect: use asmlinkage in i386 syscall table prototype
Date: Thu, 6 Dec 2007 15:20:14 -0800 [thread overview]
Message-ID: <11969832193635-git-send-email-zach.brown@oracle.com> (raw)
In-Reply-To: <1196983219534-git-send-email-zach.brown@oracle.com>
call_indirect() was using the wrong calling convention for the system call
handlers. system call handlers would get mixed up arguments.
Signed-off-by: Zach Brown <zach.brown@oracle.com>
diff --git a/include/asm-x86/indirect_32.h b/include/asm-x86/indirect_32.h
index a1b72ac..e3dea8e 100644
--- a/include/asm-x86/indirect_32.h
+++ b/include/asm-x86/indirect_32.h
@@ -15,8 +15,8 @@ struct indirect_registers {
static inline long call_indirect(struct indirect_registers *regs)
{
- extern long (*sys_call_table[]) (__u32, __u32, __u32, __u32, __u32, __u32);
-
+ extern asmlinkage long (*sys_call_table[])(long, long, long,
+ long, long, long);
return sys_call_table[INDIRECT_SYSCALL(regs)](regs->ebx, regs->ecx,
regs->edx, regs->esi,
regs->edi, regs->ebp);
--
1.5.2.2
next prev parent reply other threads:[~2007-12-06 23:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 23:20 syslets v7: back to basics Zach Brown
2007-12-06 23:20 ` Zach Brown [this message]
2007-12-06 23:20 ` [PATCH 2/6] syslet: asm-generic support to disable syslets Zach Brown
2007-12-06 23:20 ` [PATCH 3/6] syslet: introduce abi structs Zach Brown
2007-12-06 23:20 ` [PATCH 4/6] syslets: add indirect args Zach Brown
2007-12-06 23:20 ` [PATCH 5/6] syslets: add generic syslets infrastructure Zach Brown
2007-12-06 23:20 ` [PATCH 6/6] syslets: add both 32bit and 64bit x86 syslet support Zach Brown
2007-12-07 11:55 ` [PATCH 5/6] syslets: add generic syslets infrastructure Evgeniy Polyakov
2007-12-07 18:24 ` Zach Brown
2008-01-09 2:03 ` Rusty Russell
2008-01-09 3:00 ` Zach Brown
2008-01-09 3:48 ` Rusty Russell
2008-01-09 18:16 ` Zach Brown
2008-01-09 22:04 ` Rusty Russell
2008-01-09 22:58 ` Linus Torvalds
2008-01-09 23:05 ` Linus Torvalds
2008-01-09 23:47 ` Zach Brown
2008-01-10 1:18 ` Rusty Russell
2008-01-09 23:15 ` Davide Libenzi
2008-01-10 5:41 ` Jeff Garzik
2007-12-08 12:40 ` [PATCH 1/6] indirect: use asmlinkage in i386 syscall table prototype Simon Holm Thøgersen
2007-12-08 21:22 ` Zach Brown
2007-12-08 12:52 ` [PATCH] Fix casting on architectures with 32-bit pointers/longs Simon Holm Thøgersen
2007-12-10 19:46 ` syslets v7: back to basics Jens Axboe
2007-12-10 21:30 ` Phillip Susi
2007-12-10 22:15 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11969832193635-git-send-email-zach.brown@oracle.com \
--to=zach.brown@oracle.com \
--cc=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=dan.j.williams@gmail.com \
--cc=davem@davemloft.net \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=jmoyer@redhat.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=odie@cs.aau.dk \
--cc=suparna@in.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).