From: James Bottomley <James.Bottomley@SteelEye.com>
To: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
dm-devel@redhat.com, j-nomura@ce.jp.nec.com,
bharrosh@panasas.com
Subject: Re: [PATCH 27/30] blk_end_request: changing scsi (take 4)
Date: Wed, 12 Dec 2007 07:55:16 -0500 [thread overview]
Message-ID: <1197464116.4203.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20071211.175209.10128473.k-ueda@ct.jp.nec.com>
On Tue, 2007-12-11 at 17:52 -0500, Kiyoshi Ueda wrote:
> This patch converts scsi mid-layer to use blk_end_request interfaces.
> Related 'uptodate' arguments are converted to 'error'.
>
> As a result, the interface of internal function, scsi_end_request(),
> is changed.
This looks fine, as far as it goes.
One of the things that might actually be useful in future is as well as
communicating the error, the ability to say more information about what
happened. For instance dm-mp needs to know whether the error is
transport or device related (the former being retryable on a different
path).
James
prev parent reply other threads:[~2007-12-12 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 22:52 [PATCH 27/30] blk_end_request: changing scsi (take 4) Kiyoshi Ueda
2007-12-12 12:55 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197464116.4203.23.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=bharrosh@panasas.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jens.axboe@oracle.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).