* [PATCH] blk-mq: make __blk_mq_stop_hw_queues static
@ 2017-05-08 10:44 Colin King
2017-05-08 14:09 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-05-08 10:44 UTC (permalink / raw)
To: Jens Axboe, linux-block; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Making __blk_mq_stop_hw_queues static fixes sparse warning:
block/blk-mq.c:6: warning: symbol '__blk_mq_stop_hw_queues' was not
declared. Should it be static?
Fixes: 2719aa217e0d0 ("blk-mq: don't use sync workqueue flushing from drivers")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
block/blk-mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 5d4ce7eb8dbf..5385fc89a6d2 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1236,7 +1236,7 @@ void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx)
}
EXPORT_SYMBOL(blk_mq_stop_hw_queue);
-void __blk_mq_stop_hw_queues(struct request_queue *q, bool sync)
+static void __blk_mq_stop_hw_queues(struct request_queue *q, bool sync)
{
struct blk_mq_hw_ctx *hctx;
int i;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-mq: make __blk_mq_stop_hw_queues static
2017-05-08 10:44 [PATCH] blk-mq: make __blk_mq_stop_hw_queues static Colin King
@ 2017-05-08 14:09 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2017-05-08 14:09 UTC (permalink / raw)
To: Colin King, linux-block; +Cc: kernel-janitors, linux-kernel
On 05/08/2017 04:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Making __blk_mq_stop_hw_queues static fixes sparse warning:
>
> block/blk-mq.c:6: warning: symbol '__blk_mq_stop_hw_queues' was not
> declared. Should it be static?
Thanks, added.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-08 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 10:44 [PATCH] blk-mq: make __blk_mq_stop_hw_queues static Colin King
2017-05-08 14:09 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).