linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomas Marek <marek_tomas@centrum.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, joe@perches.com,
	linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c
Date: Fri, 8 Dec 2017 13:34:03 -0800	[thread overview]
Message-ID: <11cac73a-90f0-f4c3-069f-711526ed55eb@centrum.cz> (raw)
In-Reply-To: <20171206150123.GA9143@kroah.com>

On 12/06/2017 07:01 AM, Greg KH wrote:

> On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote:
>> This patch fix several brace on next line, braces not necessary, space
>> around =/<, and space before/after open/close parenthesis coding style
>> errors find by checkpatch in pi433_if.c.
>>
>> In addition, the interrupt routine DIO0_irq_handler logic is updated:
>> - use 'switch' statement instead of 'if/else if' combination for the
>>   sake of readability, and
>> - use dev_dbg_ratelimited instead of dev_dbg to avoid message flooding.
> When you have to add "in addition" to a changelog comment, that's a huge
> flag that the patch needs to be broken up into a patch series.  Please
> do that here, only doing one "logical" thing at a time.  As it is, it's
> hard to review this way.
>
> thanks,
>
> greg k-h
OK, I see, no problem.

Thanks

Tomas

      reply	other threads:[~2017-12-08 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 20:40 [PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c Tomas Marek
2017-12-06 15:01 ` Greg KH
2017-12-08 21:34   ` Tomas Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11cac73a-90f0-f4c3-069f-711526ed55eb@centrum.cz \
    --to=marek_tomas@centrum.cz \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).