From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, khilman@baylibre.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: meson8b: add the thermal-zones with cooling configuration
Date: Mon, 11 Jan 2021 15:04:32 +0100 [thread overview]
Message-ID: <11cd42bd-6b5f-f126-d53e-e06693b8000b@baylibre.com> (raw)
In-Reply-To: <20201221181306.904272-5-martin.blumenstingl@googlemail.com>
On 21/12/2020 19:13, Martin Blumenstingl wrote:
> The vendor kernel uses the following thermal-zone settings:
> <= 70°C:
> - CPU frequency limited to 1.488GHz
> - GPU limited to 511MHz and 2 cores (pixel processors)
>
> <= 80°C:
> - CPU frequency limited to 1.2GHz
> - GPU limited to 435MHz and 2 cores (pixel processors)
>
> <= 90°C:
> - CPU frequency limited to 0.804GHz
> - GPU limited to 328MHz and 1 core (pixel processor)
>
> Add simplified thermal configuration which is taken from the
> GXBB/GXL/GXM SoC family (which uses the same manufacturing process and
> has the same maximum junction temperature of 125°C). With this the
> thermal framework will try to keep the SoC temperature at or below 80°C
> which is identical to the vendor kernel (with the exception of one CPU
> frequency step from 1.488GHz to 1.536GHz).
>
> The number of GPU cores are not taken into account as this is not
> supported.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 54 ++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index 2401cdf5f751..dbf7963b6c87 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -10,6 +10,7 @@
> #include <dt-bindings/power/meson8-power.h>
> #include <dt-bindings/reset/amlogic,meson8b-reset.h>
> #include <dt-bindings/reset/amlogic,meson8b-clkc-reset.h>
> +#include <dt-bindings/thermal/thermal.h>
> #include "meson.dtsi"
>
> / {
> @@ -26,6 +27,7 @@ cpu0: cpu@200 {
> resets = <&clkc CLKC_RESET_CPU0_SOFT_RESET>;
> operating-points-v2 = <&cpu_opp_table>;
> clocks = <&clkc CLKID_CPUCLK>;
> + #cooling-cells = <2>; /* min followed by max */
> };
>
> cpu1: cpu@201 {
> @@ -37,6 +39,7 @@ cpu1: cpu@201 {
> resets = <&clkc CLKC_RESET_CPU1_SOFT_RESET>;
> operating-points-v2 = <&cpu_opp_table>;
> clocks = <&clkc CLKID_CPUCLK>;
> + #cooling-cells = <2>; /* min followed by max */
> };
>
> cpu2: cpu@202 {
> @@ -48,6 +51,7 @@ cpu2: cpu@202 {
> resets = <&clkc CLKC_RESET_CPU2_SOFT_RESET>;
> operating-points-v2 = <&cpu_opp_table>;
> clocks = <&clkc CLKID_CPUCLK>;
> + #cooling-cells = <2>; /* min followed by max */
> };
>
> cpu3: cpu@203 {
> @@ -59,6 +63,7 @@ cpu3: cpu@203 {
> resets = <&clkc CLKC_RESET_CPU3_SOFT_RESET>;
> operating-points-v2 = <&cpu_opp_table>;
> clocks = <&clkc CLKID_CPUCLK>;
> + #cooling-cells = <2>; /* min followed by max */
> };
> };
>
> @@ -167,6 +172,54 @@ hwrom@0 {
> };
> };
>
> + thermal-zones {
> + soc {
> + polling-delay-passive = <250>; /* milliseconds */
> + polling-delay = <1000>; /* milliseconds */
> + thermal-sensors = <&thermal_sensor>;
> +
> + cooling-maps {
> + map0 {
> + trip = <&soc_passive>;
> + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&mali THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> +
> + map1 {
> + trip = <&soc_hot>;
> + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&mali THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> +
> + trips {
> + soc_passive: soc-passive {
> + temperature = <80000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "passive";
> + };
> +
> + soc_hot: soc-hot {
> + temperature = <90000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "hot";
> + };
> +
> + soc_critical: soc-critical {
> + temperature = <110000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "critical";
> + };
> + };
> + };
> + };
> +
> mmcbus: bus@c8000000 {
> compatible = "simple-bus";
> reg = <0xc8000000 0x8000>;
> @@ -221,6 +274,7 @@ mali: gpu@c0000 {
> clocks = <&clkc CLKID_CLK81>, <&clkc CLKID_MALI>;
> clock-names = "bus", "core";
> operating-points-v2 = <&gpu_opp_table>;
> + #cooling-cells = <2>; /* min followed by max */
> };
> };
> }; /* end of / */
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2021-01-11 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 18:13 [PATCH 0/5] Thermal zone configuration for Meson8/Meson8b/Meson8m2 Martin Blumenstingl
2020-12-21 18:13 ` [PATCH 1/5] ARM: dts: meson: move iio-hwmon for the SoC temperature to meson.dtsi Martin Blumenstingl
2021-01-11 14:03 ` Neil Armstrong
2020-12-21 18:13 ` [PATCH 2/5] ARM: dts: meson: add the ADC thermal sensor " Martin Blumenstingl
2021-01-11 14:03 ` Neil Armstrong
2020-12-21 18:13 ` [PATCH 3/5] ARM: dts: meson8: add the thermal-zones with cooling configuration Martin Blumenstingl
2021-01-11 14:04 ` Neil Armstrong
2020-12-21 18:13 ` [PATCH 4/5] ARM: dts: meson8b: " Martin Blumenstingl
2021-01-11 14:04 ` Neil Armstrong [this message]
2020-12-21 18:13 ` [PATCH 5/5] ARM: multi_v7_defconfig: Enable support for the ADC thermal sensor Martin Blumenstingl
2021-01-25 18:42 ` [PATCH 0/5] Thermal zone configuration for Meson8/Meson8b/Meson8m2 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11cd42bd-6b5f-f126-d53e-e06693b8000b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).