From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by smtp.subspace.kernel.org (Postfix) with SMTP id 294FE17727 for ; Tue, 27 Feb 2024 03:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.131.102.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709003109; cv=none; b=CvqFfZgbOSkPitorkQcQg17ELucUtDXOZ8wxmg+k1scI0VaAY9YVROBULrXlP553abWqXaf4DclCdX9GaPnvyO4Uhp4+dOZ32eMJ2vY/i5g25xxXG69scWttsFkrD1jQqARyHwcvU+ceN4XOc335GzJbSE7aZJvac7AcfGar8zU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709003109; c=relaxed/simple; bh=flJpjWg4G590GoBdzqL83kC4185Wq8tCMo9iI0foqpo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=usRpvHHzwkbP4fRsceyYj0XMSUCL+VQ7hSb8vwosIqw2VcFe+AX9EmmwN7ECWRYoccSQSj7TEVP4q7XywjnTE+Dk+3Rv0Mz4zlFubkZt45Qts3a1+MMGgoh6ewpW9iWBOpVwkaldZY1Vx8fADDUVVHGEGPCvCsy+IMEUwrUzqSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=rowland.harvard.edu; spf=pass smtp.mailfrom=netrider.rowland.org; arc=none smtp.client-ip=192.131.102.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netrider.rowland.org Received: (qmail 753798 invoked by uid 1000); 26 Feb 2024 22:05:06 -0500 Date: Mon, 26 Feb 2024 22:05:06 -0500 From: Alan Stern To: "Martin K. Petersen" Cc: Oliver Neukum , syzbot , bvanassche@acm.org, emilne@redhat.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com, tasos@tasossah.com, usb-storage@lists.one-eyed-alien.net Subject: Re: [syzbot] [usb-storage?] divide error in isd200_ata_command Message-ID: <11ec2091-71c2-4dfb-be36-0cc21be32109@rowland.harvard.edu> References: <0000000000003eb868061245ba7f@google.com> <99b0fb1b-37b3-4da4-8129-e502ed8e479a@suse.com> <9bbc5b63-33e3-44de-8bce-4c59dcce5e92@rowland.harvard.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 26, 2024 at 09:46:39PM -0500, Martin K. Petersen wrote: > > Alan, > > >> in isd200_scsi_to_ata() because it must not be called before > >> isd200_get_inquiry_data() has completed. > > > > It can't be; isd200_get_inquiry_data is called by > > isd200_Initialization during probe before any SCSI commands are > > transmitted. > > How do we end up with bad inquiry data (or rather bad ATA ID data)? The data doesn't come from an actual ISD200 device. It's from a deliberately faulty (for the obvious reason) emulation in userspace, created by the syzbot test code. Alan Stern