From: "Alexander van Heukelum" <heukelum@fastmail.fm>
To: "Ingo Molnar" <mingo@elte.hu>,
"Alexander van Heukelum" <heukelum@mailshack.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: remove superfluous initialisation in boot code.
Date: Mon, 07 Apr 2008 11:13:35 +0200 [thread overview]
Message-ID: <1207559615.27658.1246448421@webmail.messagingengine.com> (raw)
In-Reply-To: <20080407074614.GD2368@elte.hu>
On Mon, 7 Apr 2008 09:46:14 +0200, "Ingo Molnar" <mingo@elte.hu> said:
>
> * Alexander van Heukelum <heukelum@mailshack.com> wrote:
>
> > --- a/arch/x86/boot/compressed/misc.c
> > +++ b/arch/x86/boot/compressed/misc.c
> > @@ -223,7 +223,7 @@ static memptr free_mem_end_ptr;
> > #define HEAP_SIZE 0x4000
> > #endif
> >
> > -static char *vidmem = (char *)0xb8000;
> > +static char *vidmem;
> > static int vidport;
>
> thanks, applied. (Btw., you forgot your signoff line - not a big deal
> for a small fix like this but it's best to always include it for patches
> you'd like to see go upstream.)
Hmm... I knew I had forgotten something. So I did another round of tests
to see if it was working correctly :-/.
If you like, you can add:
Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
Greetings,
Alexander
> Ingo
--
Alexander van Heukelum
heukelum@fastmail.fm
--
http://www.fastmail.fm - And now for something completely different…
next prev parent reply other threads:[~2008-04-07 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 12:47 [PATCH] x86: remove superfluous initialisation in boot code Alexander van Heukelum
2008-04-07 7:46 ` Ingo Molnar
2008-04-07 9:13 ` Alexander van Heukelum [this message]
2008-04-07 10:00 ` (no subject) zhenwenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207559615.27658.1246448421@webmail.messagingengine.com \
--to=heukelum@fastmail.fm \
--cc=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).