From: Heiko Stuebner <heiko@sntech.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add basic dts for RK3308 EVB
Date: Fri, 18 Oct 2019 01:39:58 +0200 [thread overview]
Message-ID: <120878573.PH0Dm224ES@phil> (raw)
In-Reply-To: <20191017030520.32420-1-andy.yan@rock-chips.com>
Hi Andy,
Am Donnerstag, 17. Oktober 2019, 05:05:20 CEST schrieb Andy Yan:
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index c82c5e57d44c..b680c4b8b2c9 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -447,6 +447,11 @@ properties:
> - const: rockchip,r88
> - const: rockchip,rk3368
>
> + - description: Rockchip RK3308 Evaluation board
> + items:
> + - const: rockchip,rk3308-evb
> + - const: rockchip,rk3308
> +
> - description: Rockchip RK3228 Evaluation board
> items:
> - const: rockchip,rk3228-evb
Rob likes the binding addition to be a separate patch.
> + vdd_log: vdd_core: vdd-core {
> + compatible = "pwm-regulator";
> + pwms = <&pwm0 0 5000 1>;
> + regulator-name = "vdd_core";
> + regulator-min-microvolt = <827000>;
> + regulator-max-microvolt = <1340000>;
> + regulator-init-microvolt = <1015000>;
> + regulator-early-min-microvolt = <1015000>;
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-settling-time-up-us = <250>;
> + status = "okay";
It's a board-regulator, so always "okay", no need for a status.
In general for regulators, please create an actual regulator tree, with
correctly modelled supply-chains following the naming according
to the board schematics. See for example rk3399-gru for a nice example.
> + };
> +
> + vdd_1v0: vdd-1v0 {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_1v0";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
As noted above, missing vin-supply
> + };
> +
> + vccio_flash: vccio-flash {
> + compatible = "regulator-fixed";
> + regulator-name = "vccio_flash";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + vcc_phy: vcc-phy-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_phy";
> + regulator-always-on;
> + regulator-boot-on;
This is the classic example of not following the schematics.
I.e. no Rockchip board I know has a regulator named "vcc_phy"
that is completely unconnected, yet all boards in the vendor tree
have this regulator ;-) ... so as I said, please follow the schematics.
> + };
> +
> + vbus_host: vbus-host-regulator {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_drv>;
> + regulator-name = "vbus_host";
> + };
> +};
> +
Thanks
Heiko
prev parent reply other threads:[~2019-10-17 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 3:02 [PATCH 0/2] Add basic dts support for RK3308 Andy Yan
2019-10-17 3:04 ` [PATCH 1/2] arm64: dts: rockchip: Add core dts for RK3308 SOC Andy Yan
2019-10-17 23:30 ` Heiko Stuebner
2019-10-21 9:09 ` Andy Yan
2019-10-17 3:05 ` [PATCH 2/2] arm64: dts: rockchip: Add basic dts for RK3308 EVB Andy Yan
2019-10-17 23:39 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120878573.PH0Dm224ES@phil \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).