From: Ben Collins <ben.collins@canonical.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-kernel@vger.kernel.org, Samuel Ortiz <samuel@sortiz.org>
Subject: Re: [PATCH 4/7] nsc-ircc: Default to dongle type 9 on IBM hardware
Date: Mon, 21 Jul 2008 13:40:57 -0400 [thread overview]
Message-ID: <1216662057.7585.153.camel@cunning> (raw)
In-Reply-To: <1216618176.8411.124.camel@violet.holtmann.net>
CC: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: Ben Collins <ben.collins@canonical.com>
diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c
index effc1ce..18d1714 100644
--- a/drivers/net/irda/nsc-ircc.c
+++ b/drivers/net/irda/nsc-ircc.c
@@ -151,8 +151,8 @@ static char *dongle_types[] = {
static chipio_t pnp_info;
static const struct pnp_device_id nsc_ircc_pnp_table[] = {
{ .id = "NSC6001", .driver_data = 0 },
- { .id = "IBM0071", .driver_data = 0 },
{ .id = "HWPC224", .driver_data = 0 },
+ { .id = "IBM0071", .driver_data = NSC_FORCE_DONGLE_TYPE9 },
{ }
};
@@ -930,7 +930,10 @@ static int nsc_ircc_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *i
pnp_info.dma = -1;
pnp_succeeded = 1;
- /* There don't seem to be any way to get the cfg_base.
+ if (id->driver_data & NSC_FORCE_DONGLE_TYPE9)
+ dongle_id = 0x9;
+
+ /* There doesn't seem to be any way of getting the cfg_base.
* On my box, cfg_base is in the PnP descriptor of the
* motherboard. Oh well... Jean II */
diff --git a/drivers/net/irda/nsc-ircc.h b/drivers/net/irda/nsc-ircc.h
index 29398a4..71cd3c5 100644
--- a/drivers/net/irda/nsc-ircc.h
+++ b/drivers/net/irda/nsc-ircc.h
@@ -35,6 +35,9 @@
#include <linux/types.h>
#include <asm/io.h>
+/* Features for chips (set in driver_data) */
+#define NSC_FORCE_DONGLE_TYPE9 0x00000001
+
/* DMA modes needed */
#define DMA_TX_MODE 0x08 /* Mem to I/O, ++, demand. */
#define DMA_RX_MODE 0x04 /* I/O to mem, ++, demand. */
next prev parent reply other threads:[~2008-07-21 17:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 15:57 [PATCH 0/7] Patches from Ubuntu kernel tree Ben Collins
2008-01-02 15:57 ` [PATCH 1/7] netfilter: Export ip6t_mh.h and xt_quota.h for iptables build Tim Gardner
2008-07-22 8:55 ` Jan Engelhardt
2008-07-22 10:45 ` Patrick McHardy
2008-01-18 18:21 ` [PATCH 2/7] ata: blacklist FUJITSU MHW2160BH PL Chuck Short
2008-07-31 5:45 ` Jeff Garzik
2008-07-20 21:08 ` [PATCH 4/7] irda: Default to dongle type 9 on IBM hardware Matthew Garrett
2008-07-21 5:29 ` Marcel Holtmann
2008-07-21 17:40 ` Ben Collins [this message]
2008-07-29 2:46 ` [PATCH 4/7] nsc-ircc: " Andrew Morton
2008-07-30 1:44 ` Matthew Garrett
2008-07-30 2:16 ` Andrew Morton
2008-07-30 5:11 ` Matthew Garrett
2008-07-30 14:17 ` Ben Collins
2008-07-20 21:44 ` [PATCH 7/7] HID: Add quirks for fourth generation MacBooks (4,1) Alexandre Karpenko
2008-07-21 1:45 ` [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices Ben Collins
2008-07-21 5:08 ` Marcel Holtmann
2008-07-21 5:54 ` Ben Collins
2008-07-21 16:00 ` Ben Collins
2008-07-21 23:30 ` Marcel Holtmann
2008-07-21 1:48 ` [PATCH 6/7] pm: Config option to disable handling of console during suspend/resume Ben Collins
2008-07-29 3:33 ` Greg KH
2008-07-29 21:15 ` Rafael J. Wysocki
2008-07-29 21:51 ` Ben Collins
2008-07-29 22:18 ` Rafael J. Wysocki
2008-07-30 4:47 ` Greg KH
2008-07-30 14:20 ` Ben Collins
2008-08-04 6:28 ` Pavel Machek
2008-08-07 21:23 ` Ben Collins
2008-08-07 21:43 ` Rafael J. Wysocki
2008-07-21 1:54 ` [PATCH 5/7] [airprime] Add support for more devices Ben Collins
2008-07-29 2:58 ` Andrew Morton
2008-07-29 3:17 ` Greg KH
2008-07-29 3:30 ` Greg KH
2008-07-29 14:20 ` Ben Collins
2008-07-29 15:53 ` Kevin Lloyd
2008-07-29 3:35 ` [PATCH 0/7] Patches from Ubuntu kernel tree Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216662057.7585.153.camel@cunning \
--to=ben.collins@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mjg59@srcf.ucam.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).