From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447AbYHNRM6 (ORCPT ); Thu, 14 Aug 2008 13:12:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751286AbYHNRMs (ORCPT ); Thu, 14 Aug 2008 13:12:48 -0400 Received: from mtagate6.de.ibm.com ([195.212.29.155]:65427 "EHLO mtagate6.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbYHNRMr (ORCPT ); Thu, 14 Aug 2008 13:12:47 -0400 Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros. From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com To: Tim Hockin Cc: Rusty Russell , Jan Kara , Pavel Machek , lf_kernel_messages@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joe Perches , Greg Kroah-Hartman , Jochen =?ISO-8859-1?Q?Vo=DF?= , Sam Ravnborg , Kunai Takashi , Andrew Morton , linux-s390@vger.kernel.org, Gerrit Huizenga , Michael Holzheu , Randy Dunlap , Tim Bird In-Reply-To: References: <20080730165656.118280544@de.ibm.com> <200808131433.02966.rusty@rustcorp.com.au> <200808141153.03269.rusty@rustcorp.com.au> Content-Type: text/plain Organization: IBM Corporation Date: Thu, 14 Aug 2008 19:11:50 +0200 Message-Id: <1218733910.2651.20.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2008-08-14 at 08:40 -0700, Tim Hockin wrote: > On Aug 13, 2008 9:15 PM, "Rusty Russell" wrote: > > > On Wednesday 13 August 2008 17:04:11 Tim Hockin wrote: > >> But there are a number of places that have ...Well, if they're to be the > >> same messages under the manual-numbering scheme, > > > > someone has to verify that they are really the same anyway. Not much more > > work to simply fix them in that case, is it? > > > > If it improves normal kernel messages, then everyone wins. > > Oh, I agree with that. I personally don't care much for the msg ID part of > this patch (I mean I don't care either way). It might be nice to have man > pages, but I just see it becoming out of sync, duplicate numbers, etc. No, the kmsg-doc script will prevent that the kmsg message will become of of sync and it checks for duplicate numbers. The idea here is that the kmsg man pages are generated with the kernel compile (just try it with "make D=2"). > What I want to see is the elevation of these call-sites from "it's just a > printk()" to "it's a report-worthy event and part of our user<->kernel API". I > want people to add them when it's appropriate and then not change the strings > later. I don't care if, in the end, they are structured strings. I do care if > I have to run dozens of regexes against thousands of log-lines on thousands of > systems. > > :) Yes, and this has already happened with the s390 device driver messages. With the conversion to kmsg our developers removed a lot of crud from the code, this alone makes it worthwhile. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.