From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: roel kluin <roel.kluin@gmail.com>
Cc: paulus@samba.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON
Date: Tue, 19 Aug 2008 07:42:13 +1000 [thread overview]
Message-ID: <1219095733.28339.77.camel@pasglop> (raw)
In-Reply-To: <48A9F8E9.8030303@gmail.com>
On Mon, 2008-08-18 at 18:34 -0400, roel kluin wrote:
> untested, is it correct?
Your patch is correct. The bug is quite harmless thankfully :-)
Ben.
> arch/powerpc/include/asm/pmac_feature.h:359:
> #define MACIO_FLAG_SCCA_ON 0x00000001
> #define MACIO_FLAG_SCCB_ON 0x00000002
> ---
> duplicate test of MACIO_FLAG_SCCB_ON
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 5169ecc..e6c0040 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
> macio_chips[i].of_node = node;
> macio_chips[i].type = type;
> macio_chips[i].base = base;
> - macio_chips[i].flags = MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
> + macio_chips[i].flags = MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
> macio_chips[i].name = macio_names[type];
> revp = of_get_property(node, "revision-id", NULL);
> if (revp)
prev parent reply other threads:[~2008-08-18 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 22:34 [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON roel kluin
2008-08-18 21:42 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219095733.28339.77.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).