From: Bert Vermeulen <bert@biot.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Birger Koblitz <mail@birger-koblitz.de>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller
Date: Tue, 5 Jan 2021 09:43:59 +0100 [thread overview]
Message-ID: <121d9dc6-7993-d43b-291f-74dd943f4fc6@biot.com> (raw)
In-Reply-To: <20210104213131.GL5645@sirena.org.uk>
On 1/4/21 10:31 PM, Mark Brown wrote:
> On Fri, Jan 01, 2021 at 02:24:31PM +0100, Bert Vermeulen wrote:
>
>> + compatible:
>> + const: realtek,rtl-spi
>
> This is still just using rtl-spi as the compatible string, please
> address the feedback on the previous version.
Mark,
The rtl prefix really is as close as it gets. This is being developed on
RTL838x and RTL839x, but the driver very likely also works on RTL8196C and
RTL93xx series. There's no difference to the SPI block in those SoCs.
Do you really want a different per-series compatible when the "IP block" was
just copy-pasted between series in hardware?
--
Bert Vermeulen
bert@biot.com
next prev parent reply other threads:[~2021-01-05 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 13:24 [PATCH v3 0/2] spi: Add support for Realtek RTL838x/RTL839x SoC SPI Bert Vermeulen
2021-01-01 13:24 ` [PATCH v3 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller Bert Vermeulen
2021-01-04 21:31 ` Mark Brown
2021-01-05 8:43 ` Bert Vermeulen [this message]
2021-01-05 13:47 ` Mark Brown
2021-01-01 13:24 ` [PATCH v3 2/2] spi: realtek-rtl: Add support for Realtek RTL838x/RTL839x SoC SPI controllers Bert Vermeulen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121d9dc6-7993-d43b-291f-74dd943f4fc6@biot.com \
--to=bert@biot.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).