From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755961AbcIMINd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Sep 2016 04:13:33 -0400
Received: from mout.web.de ([212.227.15.3]:61763 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751042AbcIMINc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Sep 2016 04:13:32 -0400
Subject: Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in
 rbd_header_from_disk()
To: Ilya Dryomov <idryomov@gmail.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <57806eb1-10ed-582e-72d0-2975e1ee967a@users.sourceforge.net>
 <71b06567-1ea9-204d-d61b-2af4426d9cd1@users.sourceforge.net>
 <CAOi1vP9iQ6u7dm0dRMg4rs6tLaR5mv55yew0URTX00-y6C0S6g@mail.gmail.com>
Cc: ceph-devel@vger.kernel.org, Alex Elder <elder@kernel.org>,
        Sage Weil <sage@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <121f05b0-ac94-4d81-289e-9dc3668eab95@users.sourceforge.net>
Date: Tue, 13 Sep 2016 10:12:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAOi1vP9iQ6u7dm0dRMg4rs6tLaR5mv55yew0URTX00-y6C0S6g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:oHwN+vrykwN7jdCkVAfS+HQzk7fotJvd+DrAQjWzTS8pASsfm+S
 DgKFMf8gK+t8Nyor8QxSKeFgPDpGhlqx4vEpdvHvRmo5iC1lsfZIWPWtJYZ4PPMWayR7vXb
 e4Gb4rU2UUmiLNO0lnR6xR81JtBpQ3vyy8qqWH74zUGH9AVSuEerHRKzaK+eu4llJX0uHP3
 56YeacC3yXYf76wpPlh3Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wwM1KPldCws=:bXdbh6tXz/vYMYE4ktCeNh
 VzBgDPk1CsHMH9lq9/bCwvw0IVLBhQUTqd4gwreq8tn0T2csjdkyWSYomfVpOHBIY4Ed6YF5B
 IvfQMICkfL0UdR9l8yDNCGFo9OHBUkoZyo0PuWfpRmRgj1ypt6m1ipRzS+ygG0RHG3t52yb4w
 GmxN1shxvky8w0uyiSOqFtD913Lp+ruFLOE9MwOMeRXzwTvHgmQxqKRkN0/wiJHT5lhGSFc1T
 iIwbj4r9bB/HWJOopqWELQt/2ZkkRRhNGLvkq4OPcVvhRpGlbSRZG3MGav/PyeOOsi7r5ghoq
 pAh9BTek71qfYMgNXBY+wkmnI6EGgc2YrHBpUZBzAuIQAb75ijMkJoTcqzTcAQEAJrwPi4eWw
 0zSzm9C3VOlIN0eUatgItN/vAcspHMaGdiMBSgmjWivMcKmxB3NJenYr+o+xHCxjzaWADppso
 REPbe7UCqyBEx9fMhVd8oADMqHSGsV3HuhEKo5L5Fa/wyG34JpBq8sZbOTridN5jv1zl3rv6B
 gCn1vGGwSQeRKh1NsG7THY4l14/C7NqCkxFytK0LpB1K1dfeFRQEiQ11c1iR1dW9YqJuq/ShO
 naE7z9UuY8afFxJXhTLFv069PvZREMM/XhT2hPy1ri3Bd/y/mNr9EuP6+6Dv4wMsOt7w0E2zn
 nBlQMK5MNIoDqKkfwn3uIqpvKO1mcmL1qRTIyPyDDDudII7uCleX0EmbGwPwNziClJ6BIR9//
 k4ULFEaNyZoJTNu6ilDgkO1LnpgEqBnI5cqde7zkNwgI/dTVvNXW67S/xo27FcfNkdBpdvO5M
 1lzSuIb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device *rbd_dev,
>>         header->snap_sizes = snap_sizes;
>>
>>         return 0;
>> -out_2big:
>> + out_2big:
>>         ret = -EIO;
>>         kfree(snap_sizes);
>>   free_names:
…
> Can you point where this current convention is documented?

Yes.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51

Do you find the software update "CodingStyle: Clarify and complete chapter 7" interesting?


> Certainly not in CodingStyle, AFAICT...

I suggest to look at the current version once more.


> I know some people prefer a single space in there because it makes
> "diff -p" work better, but nowadays with "git diff" this argument is
> pretty moot.

Would you like to discuss the corresponding software evolution a bit more?

Regards,
Markus