From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755690AbdLVMDy (ORCPT ); Fri, 22 Dec 2017 07:03:54 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35081 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbdLVMDv (ORCPT ); Fri, 22 Dec 2017 07:03:51 -0500 X-Google-Smtp-Source: ACJfBouNNAJFT8VGB4UJpnrC5WAODM/L/DuAZEL/hYxMUB21H/yK4IaQXiROSt52njOZr0+7q8uSdQ== Subject: Re: [PATCH v2] virt: vbox: use %pap format for printing resource_size_t To: Arnd Bergmann , Greg Kroah-Hartman Cc: Joe Perches , Larry Finger , linux-kernel@vger.kernel.org References: <20171221161529.3462263-1-arnd@arndb.de> From: Hans de Goede Message-ID: <121f58a5-c407-a604-982a-3aa61b6b006e@redhat.com> Date: Fri, 22 Dec 2017 13:03:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171221161529.3462263-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 21-12-17 17:15, Arnd Bergmann wrote: > resource_size_t may be larger than pointers depending on configuration, > so we can run into this build warning: > > drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe': > drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > > This uses the special %pap to print the address by reference. > > Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration") > Signed-off-by: Arnd Bergmann > --- > v2: Use %pap instead of the %rR that was just as incorrect, as > pointed out by Joe Perches. Thank you for fixing this, the fix looks good to me: Acked-by: Hans de Goede Regards, Hans > --- > drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c > index d045aa51ce03..82e280d38cc2 100644 > --- a/drivers/virt/vboxguest/vboxguest_linux.c > +++ b/drivers/virt/vboxguest/vboxguest_linux.c > @@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) > > vmmdev = devm_ioremap(dev, mmio, mmio_len); > if (!vmmdev) { > - vbg_err("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n", > - (void *)mmio, (int)mmio_len); > + vbg_err("vboxguest: Error ioremap failed; MMIO addr=%pap size=%pap\n", > + &mmio, &mmio_len); > goto err_disable_pcidev; > } > > @@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) > device_create_file(dev, &dev_attr_host_version); > device_create_file(dev, &dev_attr_host_features); > > - vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n", > + vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n", > gdev->misc_device.minor, pci->irq, gdev->io_port, > - (void *)mmio, (int)mmio_len); > + &mmio, &mmio_len); > > return 0; > >