From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: How do I printk <type> correctly?
Date: Fri, 24 Oct 2008 10:41:43 +0200 [thread overview]
Message-ID: <1224837703.6002.86.camel@johannes.berg> (raw)
In-Reply-To: <20081023.134005.83296775.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Thu, 2008-10-23 at 13:40 -0700, David Miller wrote:
> > An "unsigned long long" is 64-bits too even on 64-bit platforms, so
> > why the difference? Are there any differences like alignment on some
> > platforms?
>
> I invite you to go make that change and then try to fixup all the
> resulting build warnings. Some of us already made an attempt at
> some point in the past. :-/
Heh, ok. I was just curious really. I think that answers it well
enough :)
> But it's just papering over the core problem, that we can't extend
> gcc's automatic printf format type checking easily.
>
> Even if we make u64 the same type everywhere, things like sector_t
> and other types which do have to vary by architecture will need
> to be casted.
Indeed, it doesn't really help that much.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-10-24 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 11:41 How do I printk <type> correctly? Alexey Dobriyan
2008-10-23 11:51 ` David John
2008-10-23 12:06 ` Alexey Dobriyan
2008-10-23 15:13 ` Johannes Berg
2008-10-23 20:40 ` David Miller
2008-10-24 8:41 ` Johannes Berg [this message]
2008-10-28 23:11 ` Randy Dunlap
2008-10-29 6:15 ` Artem Bityutskiy
2008-10-29 8:00 ` Artem Bityutskiy
2008-10-29 15:34 ` Randy Dunlap
2008-10-29 15:36 ` Artem Bityutskiy
2008-10-29 15:43 ` Randy Dunlap
2008-11-05 18:23 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224837703.6002.86.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).