From: Harvey Harrison <harvey.harrison@gmail.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Artem Bityutskiy <dedekind@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBIFS: endian handling fixes and annotations
Date: Sat, 22 Nov 2008 19:21:29 -0800 [thread overview]
Message-ID: <1227410489.6117.1.camel@brick> (raw)
In-Reply-To: <20081122192747.GB21433@Chamillionaire.breakpoint.cc>
On Sat, 2008-11-22 at 20:27 +0100, Sebastian Andrzej Siewior wrote:
> * Artem Bityutskiy | 2008-11-21 19:19:24 [+0200]:
>
> > save_flags = mst->flags;
> >- mst->flags = cpu_to_le32(le32_to_cpu(mst->flags) | UBIFS_MST_RCVRY);
> >+ mst->flags |= cpu_to_le32(UBIFS_MST_RCVRY);
>
> another micro optimisation would be to use __constant_cpu_to_le32()
>
Nope, no difference, cpu_to_le32 does constant-detection these days and
so there ends up being no difference.
Harvey
next prev parent reply other threads:[~2008-11-23 3:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 17:19 UBIFS updates for 2.6.28 Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] UBIFS: remove printk Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] UBIFS: endian handling fixes and annotations Artem Bityutskiy
2008-11-22 19:27 ` Sebastian Andrzej Siewior
2008-11-23 3:21 ` Harvey Harrison [this message]
2008-11-23 9:28 ` Sebastian Andrzej Siewior
2008-11-23 10:05 ` Jamie Lokier
2008-11-24 14:19 ` Adrian Hunter
2008-11-24 16:46 ` Harvey Harrison
2008-12-02 9:12 ` Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] MAINTAINERS: change UBI/UBIFS git tree URLs Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] UBIFS: fix compilation warnings Artem Bityutskiy
2008-11-22 18:54 ` Sebastian Andrzej Siewior
2008-11-24 10:03 ` Adrian Hunter
2008-11-30 18:58 ` Sebastian Andrzej Siewior
2008-11-21 17:19 ` [PATCH] UBIFS: allow for gaps when dirtying the LPT Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] UBIFS: do not print scary memory allocation warnings Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] UBIFS: do not allocate too much Artem Bityutskiy
2008-11-21 17:19 ` [PATCH] UBIFS: pre-allocate bulk-read buffer Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2008-10-24 17:52 [PATCH] ubifs: endian handling fixes and annotations Harvey Harrison
2008-10-25 10:57 ` Artem Bityutskiy
2008-10-25 18:52 ` Harvey Harrison
2008-10-26 10:12 ` Artem Bityutskiy
2008-10-26 13:22 ` Artem Bityutskiy
2008-10-26 18:44 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227410489.6117.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=dedekind@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).